paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

tippy: Tranfer subs-sort tooltip to tippyjs.

Browse Source 
As zulip is tranfering its tooltip to tippy the
tooltips for subs sort options are tranfered to
use tippy instead of title. Placement is bottom.
Refer https://github.com/zulip/zulip/pull/17434.
This commit is contained in:
guptaprakhariitr
2021-04-09 07:30:31 +00:00
committed by Tim Abbott
parent 40acc9b27c
commit 720d27be6d
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/subs.js
View File

@@ -1,5 +1,6 @@
import $ from "jquery";
import _ from "lodash";
import tippy from "tippy.js";
import render_subscription from "../templates/subscription.hbs";
import render_subscription_settings from "../templates/subscription_settings.hbs";
@@ -564,19 +565,19 @@ export function setup_page(callback) {
const sort_toggler = components.toggle({
values: [
{
label_html: `<i class="fa fa-sort-alpha-asc" title="${i18n.t(
label_html: `<i class="fa fa-sort-alpha-asc tippy-bottom tippy-zulip-tooltip" data-tippy-content="${i18n.t(
"Sort by name",
)}"></i>`,
key: "by-stream-name",
},
{
label_html: `<i class="fa fa-user-o" title="${i18n.t(
label_html: `<i class="fa fa-user-o tippy-bottom tippy-zulip-tooltip" data-tippy-content="${i18n.t(
"Sort by number of subscribers",
)}"></i>`,
key: "by-subscriber-count",
},
{
label_html: `<i class="fa fa-bar-chart" title="${i18n.t(
label_html: `<i class="fa fa-bar-chart tippy-bottom tippy-zulip-tooltip" data-tippy-content="${i18n.t(
"Sort by estimated weekly traffic",
)}"></i>`,
key: "by-weekly-traffic",
@@ -589,6 +590,11 @@ export function setup_page(callback) {
});
$("#subscriptions_table .search-container").prepend(sort_toggler.get());
// place subs tooltips at bottom
tippy(".tippy-bottom", {
placement: "bottom",
});
// Reset our internal state to reflect that we're initially in
// the "Subscribed" tab if we're reopening "Manage streams".
subscribed_only = true;