paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

desktop-notification-banner: Remove the banner form the org settings.

Browse Source 
The `update_desktop_notification_banner` line removed had been added in #34865,
to handle the case of opening the default user settings panel after previously opening
the personal; notifications settings panel, and is no longer required.
This commit is contained in:
Maneesh Shukla
2025-08-04 22:32:07 +05:30
committed by GitHub
parent 52fb13a2f6
commit 74148f2e0b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/settings_notifications.ts
View File

@@ -388,8 +388,6 @@ export function set_up(settings_panel: SettingsPanel): void {
settings_object.automatically_unmute_topics_in_muted_streams_policy, settings_object.automatically_unmute_topics_in_muted_streams_policy,
); );
update_desktop_notification_banner();
$container.on("click", ".desktop-notifications-request", (e) => { $container.on("click", ".desktop-notifications-request", (e) => {
e.preventDefault(); e.preventDefault();
// This is only accessed via the notifications banner, so we // This is only accessed via the notifications banner, so we

2
web/templates/settings/notification_settings.hbs
View File

@@ -131,7 +131,9 @@
{{> settings_save_discard_widget section_name="desktop-message-settings" show_only_indicator=(not for_realm_settings) }} {{> settings_save_discard_widget section_name="desktop-message-settings" show_only_indicator=(not for_realm_settings) }}
</div> </div>
{{#if (eq prefix "user_")}}
<div class="desktop-notification-settings-banners banner-wrapper"></div> <div class="desktop-notification-settings-banners banner-wrapper"></div>
{{/if}}
{{#unless for_realm_settings}} {{#unless for_realm_settings}}
{{> ../components/action_button {{> ../components/action_button