paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract helper functions in floating_recipient_bar.js.

Browse Source 
I use shorter var names in frb_botom() and do early
return in obscured_recipient_bar().

Also, we always call exports.hide() if we don't find
a valid recipient bar to "float."
This commit is contained in:
Steve Howell
2018-12-25 20:48:06 +00:00
committed by Tim Abbott
parent 4df618f584
commit 78a3cb5887
1 changed files with 40 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
static/js/floating_recipient_bar.js
View File

@@ -5,6 +5,42 @@ var exports = {};
var is_floating_recipient_bar_showing = false;
exports.frb_bottom = function () {
var bar = $("#floating_recipient_bar");
var bar_top = bar.offset().top;
var bar_bottom = bar_top + bar.safeOuterHeight();
return bar_bottom;
};
exports.obscured_recipient_bar = function () {
// Find the recipient bar that is closed to being onscreen
// but above the "top".
// Start with the pointer's current location.
var selected_row = current_msg_list.selected_row();
if (selected_row === undefined || selected_row.length === 0) {
return;
}
var candidate = rows.get_message_recipient_row(selected_row);
if (candidate === undefined) {
return;
}
var floating_recipient_bar_bottom = exports.frb_bottom();
while (candidate.length) {
if (candidate.is(".recipient_row")) {
if (candidate.offset().top < floating_recipient_bar_bottom) {
return candidate;
}
}
candidate = candidate.prev();
}
};
function show_floating_recipient_bar() {
if (!is_floating_recipient_bar_showing) {
$("#floating_recipient_bar").css('visibility', 'visible');
@@ -52,39 +88,15 @@ exports.update = function () {
// re-apply it if we continue to detect overlap
$('.temp-show-date').removeClass('temp-show-date');
var floating_recipient_bar = $("#floating_recipient_bar");
var floating_recipient_bar_top = floating_recipient_bar.offset().top;
var floating_recipient_bar_bottom =
floating_recipient_bar_top + floating_recipient_bar.safeOuterHeight();
var floating_recipient_bar_bottom = exports.frb_bottom();
// Find the last message where the top of the recipient
// row is at least partially occluded by our box.
// Start with the pointer's current location.
var selected_row = current_msg_list.selected_row();
var current_label = exports.obscured_recipient_bar();
if (selected_row === undefined || selected_row.length === 0) {
if (!current_label) {
exports.hide();
return;
}
var candidate = rows.get_message_recipient_row(selected_row);
if (candidate === undefined) {
return;
}
while (true) {
if (candidate.length === 0) {
// We're at the top of the page and no labels are above us.
exports.hide();
return;
}
if (candidate.is(".recipient_row")) {
if (candidate.offset().top < floating_recipient_bar_bottom) {
break;
}
}
candidate = candidate.prev();
}
var current_label = candidate;
// We now know what the floating stream/topic bar should say.
// Do we show it?