paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 12:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

event_queue: Actually fix missing copy for edit-message events.

Browse Source 
Apparently, our edit-message events did not guarantee that the outer
wrapper dictionary, which is intended to be unique for each client,
was unique for every client (instead only ensuring it was unique for
each user).

This led to clients unexpectedly getting last_event_id validation
errors in this code path when a user had multiple connected clients,
because the linear ordering of event IDs within a given queue was
corrupted.

In fd2a63b049, we accidentally fixed
this issue with a different set of userdata events, without fixing the
edit-message event bug.  This commit fixes the remaining issue.
This commit is contained in:
Tim Abbott
2019-08-06 13:34:52 -07:00
parent 58adac5663
commit 7953e23d49
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/tornado/event_queue.py
View File

@@ -943,7 +943,9 @@ def process_message_update_event(event_template: Mapping[str, Any],
for client in get_client_descriptors_for_user(user_profile_id):
if client.accepts_event(user_event):
client.add_event(user_event)
# We need to do another shallow copy, or we risk
# sending the same event to multiple clients.
client.add_event(dict(user_event))
def maybe_enqueue_notifications_for_message_update(user_profile_id: UserProfile,
message_id: int,