paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Add linters to help enforce profile/base layering.

Browse Source
This commit is contained in:
Alex Vandiver
2020-10-26 15:44:49 -07:00
committed by Tim Abbott
parent e81bc19e45
commit 7b2112baf3
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tools/linter_lib/custom_check.py
View File

@@ -697,6 +697,27 @@ help_markdown_rules = RuleList(
length_exclude=markdown_docs_length_exclude,
)
puppet_rules = RuleList(
langs=['pp'],
rules=[
{'pattern': r'(include\s+|\$)zulip::(profile|base)\b',
'exclude': {
'puppet/zulip/manifests/profile/',
'puppet/zulip_ops/manifests/',
'puppet/zulip/manifests/dockervoyager.pp',
},
'description': 'Abstraction layering violation; only profiles should reference profiles or zulip::base',
},
{'pattern': r'(include\s+|\$)zulip_ops::(profile|base)\b',
'exclude': {
'puppet/zulip/manifests/',
'puppet/zulip_ops/manifests/profile/',
},
'description': 'Abstraction layering violation; only profiles should reference profiles or zulip_ops::base',
},
],
)
txt_rules = RuleList(
langs=['txt', 'text', 'yaml', 'rst', 'yml'],
rules=whitespace_rules,
@@ -711,4 +732,5 @@ non_py_rules = [
help_markdown_rules,
bash_rules,
txt_rules,
puppet_rules,
]