paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-29 02:53:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

node tests: Avoid __Rewire__ for clipboard API.

Browse Source
This commit is contained in:
Steve Howell
2021-03-06 19:28:43 +00:00
committed by Steve Howell
parent f54f7cfc33
commit 7cf62cd6b1
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
frontend_tests/node_tests/popovers.js
View File

@@ -43,8 +43,6 @@ const message_edit = zrequire("message_edit");
// Bypass some scary code that runs when we import the module.
const popovers = with_field($.fn, "popover", noop, () => zrequire("popovers"));
popovers.__Rewire__("ClipboardJS", noop);
const alice = {
email: "alice@example.com",
full_name: "Alice Smith",
@@ -98,6 +96,7 @@ function make_image_stubber() {
function test_ui(label, f) {
run_test(label, (override) => {
override(popovers, "clipboard_enable", noop);
popovers.register_click_handlers();
f(override);
});

12
static/js/popovers.js
View File

@@ -54,6 +54,12 @@ let userlist_placement = "right";
let list_of_popovers = [];
export function clipboard_enable(arg) {
// arg is a selector or element
// We extract this function for testing purpose.
return new ClipboardJS(arg);
}
function elem_to_user_id(elem) {
return Number.parseInt(elem.attr("data-user-id"), 10);
}
@@ -115,7 +121,7 @@ function init_email_clipboard() {
*/
if (copy_email_icon[0]) {
copy_email_icon.removeClass("hide_copy_icon");
const copy_email_clipboard = new ClipboardJS(copy_email_icon[0]);
const copy_email_clipboard = clipboard_enable(copy_email_icon[0]);
copy_email_clipboard.on("success", copy_email_handler);
}
}
@@ -1251,7 +1257,7 @@ export function register_click_handlers() {
e.preventDefault();
});
new ClipboardJS(".copy_link");
clipboard_enable(".copy_link");
$("body").on("click", ".copy_link", function (e) {
hide_actions_popover();
@@ -1273,7 +1279,7 @@ export function register_click_handlers() {
e.preventDefault();
});
new ClipboardJS(".copy_mention_syntax");
clipboard_enable(".copy_mention_syntax");
$("body").on("click", ".copy_mention_syntax", (e) => {
hide_all();