paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: Cleanup CachedValue class.

Browse Source 
We use a Symbol for unassigned_value_sentinel and explictly assign
the compute_value property instead of using Object.assign. Both of
these are needed to type annotate it easily.
This commit is contained in:
Priyank Patel
2021-07-13 17:30:49 +00:00
committed by Tim Abbott
parent 288fe6d388
commit 899d7bba5a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/util.js
View File

@@ -159,12 +159,12 @@ export const array_compare = function util_array_compare(a, b) {
* You must supply a option to the constructor called compute_value
* which should be a function that computes the uncached value.
*/
const unassigned_value_sentinel = {};
const unassigned_value_sentinel = Symbol("unassigned_value_sentinel");
export class CachedValue {
_value = unassigned_value_sentinel;
constructor(opts) {
Object.assign(this, opts);
this.compute_value = opts.compute_value;
}
get() {