paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_settings: Refactor code to hide or disable the web-public privacy option.

Browse Source 
This commit renames hide_or_disable_web_public_stream_privacy_option to
update_web_public_stream_privacy_option_state and also refactors the code
such that it can also be used to enable or show the option along with disabling
and hiding the option in further commit.
This commit is contained in:
Sahil Batra
2021-11-24 19:14:20 +05:30
committed by Tim Abbott
parent 15cf972a8e
commit 8a3a5f9c19
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
static/js/stream_settings_ui.js
View File

@@ -988,22 +988,29 @@ export function sub_or_unsub(sub, stream_row) {
}
}
export function hide_or_disable_web_public_stream_privacy_option(container) {
export function update_web_public_stream_privacy_option_state(container) {
const web_public_stream_elem = container.find(
`input[value='${CSS.escape(stream_data.stream_privacy_policy_values.web_public.code)}']`,
);
if (!web_public_stream_elem.is(":checked")) {
if (
!page_params.server_web_public_streams_enabled ||
!page_params.realm_enable_spectator_access
) {
web_public_stream_elem.closest(".radio-input-parent").hide();
if (
!page_params.server_web_public_streams_enabled ||
(!page_params.realm_enable_spectator_access && !web_public_stream_elem.is(":checked"))
) {
web_public_stream_elem.closest(".radio-input-parent").hide();
container
.find(".stream-privacy-values .radio-input-parent:visible:last")
.css("border-bottom", "none");
} else {
if (!web_public_stream_elem.is(":visible")) {
container
.find(".stream-privacy-values .radio-input-parent:visible:last")
.css("border-bottom", "none");
} else {
web_public_stream_elem.prop("disabled", true);
.css("border-bottom", "");
web_public_stream_elem.closest(".radio-input-parent").show();
}
web_public_stream_elem.prop(
"disabled",
!settings_data.user_can_create_web_public_streams(),
);
}
}
@@ -1030,9 +1037,7 @@ export function disable_private_stream_privacy_option(container) {
}
export function hide_or_disable_stream_privacy_options_if_required(container) {
if (!settings_data.user_can_create_web_public_streams()) {
hide_or_disable_web_public_stream_privacy_option(container);
}
update_web_public_stream_privacy_option_state(container);
if (!settings_data.user_can_create_public_streams()) {
disable_public_stream_privacy_option(container);