paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: Avoid recip.user_id defensive fallback.

Browse Source 
The recip.id || recip.user_id idiom has only been
needed for some old unit tests.

It was previously required as a bad workaround for the
local echo issue fixed in dd1a6a97bd 
where we would get `display_recipient` values added in an invalid format.
This commit is contained in:
showell
2020-01-06 15:30:00 -05:00
committed by Tim Abbott
parent 185b52e5e7
commit 96a50422f7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/message_store.js
View File

@@ -179,7 +179,7 @@ exports.add_message_metadata = function (message) {
if (people.is_my_user_id(message.sender_id)) { if (people.is_my_user_id(message.sender_id)) {
_.each(message.display_recipient, (recip) => { _.each(message.display_recipient, (recip) => {
message_user_ids.add(recip.id || recip.user_id); message_user_ids.add(recip.id);
}); });
} }
break; break;