paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

dropdown_widget: Rename active class to current_user_setting.

Browse Source 
This commit renames `active` to `current_user_setting` and
`is_item_selected` to `is_current_user_setting` to clarify
it’s the user’s current choice, not hover, and to prevent
future naming conflicts.
This commit is contained in:
Aditya Kumar Kasaudhan
2025-03-13 17:52:48 +05:30
committed by Tim Abbott
parent a59f730279
commit 9971b08cce
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/dropdown_widget.ts
View File

@@ -304,7 +304,8 @@ export class DropdownWidget {
return render_dropdown_list({
item: {
...item,
is_item_selected: item.unique_id === selected_item_unique_id,
is_current_user_setting:
item.unique_id === selected_item_unique_id,
},
});
},

2
web/styles/zulip.css
View File

@@ -2249,7 +2249,7 @@ body:not(.spectator-view) {
background-color: transparent;
}
&.active {
&.current_user_setting {
background-color: var(--background-color-active-dropdown-item);
outline: none;
}

2
web/templates/dropdown_list.hbs
View File

@@ -1,5 +1,5 @@
{{#with item}}
<li class="list-item {{#if is_item_selected}}active{{/if}}" role="presentation" data-unique-id="{{unique_id}}" data-name="{{name}}" tabindex="0">
<li class="list-item {{#if is_current_user_setting}}current_user_setting{{/if}}" role="presentation" data-unique-id="{{unique_id}}" data-name="{{name}}" tabindex="0">
{{#if description}}
<a class="dropdown-list-item-common-styles">
<span class="dropdown-list-item-name">