paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

messages: Rename convert_raw_message_to_message_with_booleans.

Browse Source
This commit is contained in:
evykassirer
2024-06-03 13:18:33 -07:00
committed by Tim Abbott
parent b557297dd2
commit 9a3263ec5d
4 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/message_helper.ts
View File

@@ -29,7 +29,8 @@ export function process_new_message(raw_message: RawMessage): Message {
return cached_msg;
}
const message_with_booleans = message_store.set_message_booleans(raw_message);
const message_with_booleans =
message_store.convert_raw_message_to_message_with_booleans(raw_message);
people.extract_people_from_message(message_with_booleans);
const sent_by_me = people.is_current_user(message_with_booleans.sender_email);

10
web/src/message_store.ts
View File

@@ -79,7 +79,8 @@ export type RawMessage = {
) &
MatchedMessage;
// We add these boolean properties to Raw message in `message_store.set_message_booleans` method.
// We add these boolean properties to Raw message in
// `message_store.convert_raw_message_to_message_with_booleans` method.
export type MessageWithBooleans = (
| Omit<RawMessage & {type: "private"}, "flags">
| Omit<RawMessage & {type: "stream"}, "flags">
@@ -129,7 +130,8 @@ export type Message = (
message_reactions?: MessageCleanReaction[];
url?: string;
// Used in `markdown.js`, `server_events.js`, and `set_message_booleans`
// Used in `markdown.js`, `server_events.js`, and
// `convert_raw_message_to_message_with_booleans`
flags?: string[];
small_avatar_url?: string; // Used in `message_avatar.hbs`
@@ -195,7 +197,9 @@ export function get_pm_full_names(user_ids: number[]): string {
return names.join(", ");
}
export function set_message_booleans(message: RawMessage): MessageWithBooleans {
export function convert_raw_message_to_message_with_booleans(
message: RawMessage,
): MessageWithBooleans {
const flags = message.flags ?? [];
function convert_flag(flag_name: string): boolean {

2
web/tests/echo.test.js
View File

@@ -31,7 +31,7 @@ const message_store = mock_esm("../src/message_store", {
update_booleans() {},
set_message_booleans() {},
convert_raw_message_to_message_with_booleans() {},
});
message_lists.current = {

6
web/tests/message_store.test.js
View File

@@ -160,9 +160,9 @@ test("message_booleans_parity", () => {
// This test asserts that both have identical behavior for the
// flags common between them.
const assert_bool_match = (flags, expected_message) => {
let set_message = {topic: "set_message_booleans", flags};
let set_message = {topic: "convert_raw_message_to_message_with_booleans", flags};
const update_message = {topic: "update_booleans"};
set_message = message_store.set_message_booleans(set_message);
set_message = message_store.convert_raw_message_to_message_with_booleans(set_message);
message_store.update_booleans(update_message, flags);
for (const key of Object.keys(expected_message)) {
assert.equal(
@@ -172,7 +172,7 @@ test("message_booleans_parity", () => {
);
assert.equal(update_message[key], expected_message[key]);
}
assert.equal(set_message.topic, "set_message_booleans");
assert.equal(set_message.topic, "convert_raw_message_to_message_with_booleans");
assert.equal(update_message.topic, "update_booleans");
};