paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 16:43:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

inputs: Set default text-color explicitly.

Browse Source 
This removes the previous slightly-lighter text shade
in light mode, and gets away from the trickiness of
`color: inherit` in dark mode.

While we could probably go with inheritance
everywhere, simply by removing the color: value on
these element, setting an explicit color variable on
the inputs here builds better confidence as to what
the color value will ultimately be.
This commit is contained in:
Karl Stolley
2025-06-13 09:55:27 -05:00
committed by Tim Abbott
parent a25000298f
commit 9e2ffe7fd5
6 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/styles/app_components.css
View File

@@ -1126,7 +1126,7 @@ input.settings_text_input {
.filter_text_input {
padding: 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border: 1px solid hsl(0deg 0% 80%);
transition:
border-color linear 0.2s,

1
web/styles/dark_theme.css
View File

@@ -121,7 +121,6 @@
#organization-settings .dropdown-widget-button {
background-color: hsl(0deg 0% 0% / 20%);
border-color: hsl(0deg 0% 0% / 60%);
color: inherit;
}
.popover-filter-input-wrapper .popover-filter-input:focus {

4
web/styles/modal.css
View File

@@ -400,7 +400,7 @@
.modal_select {
width: var(--modal-input-width);
padding: 4px 25px 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
cursor: pointer;
@@ -436,7 +436,7 @@
.modal_url_input,
.modal_text_input {
padding: 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
box-shadow: inset 0 1px 1px hsl(0deg 0% 0% / 7.5%);

12
web/styles/settings.css
View File

@@ -309,7 +309,7 @@ h3,
.settings_select,
.list_select {
padding: 0 25px 0 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
cursor: pointer;
@@ -911,13 +911,13 @@ input[type="checkbox"] {
#organization-permissions {
.dropdown-widget-button {
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
}
}
#organization-settings {
.dropdown-widget-button {
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
}
}
@@ -1611,7 +1611,7 @@ label.preferences-radio-choice-label {
.time-limit-custom-input,
.realm_jitsi_server_url_custom_input {
padding: 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border: 1px solid hsl(0deg 0% 80%);
transition:
border-color linear 0.2s,
@@ -1836,7 +1836,7 @@ label.preferences-radio-choice-label {
}
.settings_textarea {
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
background-color: hsl(0deg 0% 100%);
border-radius: 4px;
vertical-align: middle;
@@ -2259,7 +2259,7 @@ label.preferences-radio-choice-label {
.settings_url_input,
.settings_text_input {
padding: 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
box-shadow: inset 0 1px 1px hsl(0deg 0% 0% / 7.5%);

2
web/styles/widgets.css
View File

@@ -130,7 +130,7 @@
border: 1px solid hsl(0deg 0% 80%);
box-shadow: inset 0 1px 1px hsl(0deg 0% 0% / 7.5%);
border-radius: 4px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
&:focus {
border-color: hsl(206deg 80% 62% / 80%);

4
web/styles/zulip.css
View File

@@ -986,7 +986,7 @@ div.focused-message-list.is-conversation-view .recipient_row {
flex: 1;
line-height: 1.2142em;
padding: 0 5px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
@@ -1344,7 +1344,7 @@ div.toggle_resolve_topic_spinner .loading_indicator_spinner {
margin-right: 15px;
padding: 4px 6px;
color: hsl(0deg 0% 33%);
color: var(--color-text-default);
border-radius: 4px;
border: 1px solid hsl(0deg 0% 80%);
box-shadow: inset 0 1px 1px hsl(0deg 0% 0% / 7.5%);