paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

css: Use span rather than div for status_emoji elements.

Browse Source 
These being possibly `display: block` in some settings resulted in
them taking up visible space oddly if the asset failed to load.

tabbott could not reproduce the original bug, perhaps because changes
in the emoji CSS do `display: inline-block` on div.emoji, but the
logical intent for this component suggests it should be a span in any
case.

Fixes #23516.
This commit is contained in:
Ujjawal Modi
2022-12-04 00:42:47 +05:30
committed by Tim Abbott
parent 29c6b4b9f2
commit a2bcf3a77c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/templates/status_emoji.hbs
View File

@@ -1,10 +1,10 @@
{{#if emoji_alt_code}}
<div class="emoji_alt_code">&nbsp:{{emoji_name}}:</div>
<span class="emoji_alt_code">&nbsp:{{emoji_name}}:</span>
{{else if still_url}}
<img src="{{still_url}}" class="emoji status_emoji" data-animated-url="{{url}}" data-still-url="{{still_url}}" />
{{else if url}}
{{!-- note that we have no still_url --}}
<img src="{{url}}" class="emoji status_emoji" data-animated-url="{{url}}" />
{{else if emoji_code}}
<div class="emoji status_emoji emoji-{{emoji_code}}"></div>
<span class="emoji status_emoji emoji-{{emoji_code}}"></span>
{{/if}}