paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Don't update desktop notification banner in mobile.

Browse Source 
Fixes #34668
This commit is contained in:
Karl Stolley
2025-05-22 12:15:59 -05:00
committed by Tim Abbott
parent c356595ed5
commit a420dfd6cc
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/settings_notifications.ts
View File

@@ -89,6 +89,16 @@ function rerender_ui(): void {
}
function update_notification_banner(): void {
// As is also noted in `navbar_alerts.ts`, notifications *basically*
// don't work on any mobile platforms, so don't event show the banners.
// This prevents trying to access things that don't exist, like
// `Notification.permission` in a mobile context, in which we'll also
// hide the ability to send a test notification before exiting with an
// early return.
if (util.is_mobile()) {
$(".send_test_notification").hide();
return;
}
const permission = Notification.permission;
const $banner_container = $(".desktop-notification-settings-banners");
if (permission === "granted") {
@@ -374,6 +384,9 @@ export function set_up(settings_panel: SettingsPanel): void {
$("#settings_content").on("click", ".request-desktop-notifications", (e) => {
e.preventDefault();
// This is only accessed via the notifications banner, so we
// do not need to do a mobile check here--as that banner is
// not shown in a mobile context anyway.
void Notification.requestPermission().then((permission) => {
if (permission === "granted") {
update_notification_banner();