paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 16:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

narrow-banner: Update empty title for "pm-with" multiple users.

Browse Source 
Instead of using "these people", we use "these users".

Note that the "pm-with" single user case has already been updated
to show the user's full name instead of "this person".
This commit is contained in:
Lauryn Menard
2022-11-08 12:56:56 +01:00
committed by Tim Abbott
parent c4d407e992
commit aac76bb185
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/narrow.js
View File

@@ -438,7 +438,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
assert.equal(
$(".empty_feed_notice_main").html(),
empty_narrow_html(
"translated: You have no private messages with these people yet.",
"translated: You have no private messages with these users yet.",
'translated HTML: Why not <a href="#" class="empty_feed_compose_private">start the conversation</a>?',
),
);

2
static/js/narrow_banner.js
View File

@@ -348,7 +348,7 @@ function pick_empty_narrow_banner() {
};
}
return {
title: $t({defaultMessage: "You have no private messages with these people yet."}),
title: $t({defaultMessage: "You have no private messages with these users yet."}),
html: $t_html(
{
defaultMessage: "Why not <z-link>start the conversation</z-link>?",