paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

design: Adjust the visibility of the spinner icon.

Browse Source 
The spinner icon is not visible until the user clicks on topic_edit_save,
so the space alloted to spinner-icon looks empty for rest of the time.
To improve the design, the spinner icon is only shown when the user
clicks on topic_edit_save.
This commit is contained in:
Nikhil Maske
2021-01-27 12:04:22 +05:30
committed by Tim Abbott
parent 03879eec6d
commit aadd42f9e8
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/message_edit.js
View File

@@ -175,6 +175,7 @@ exports.show_topic_edit_spinner = function (row) {
spinner.css({height: ""}); spinner.css({height: ""});
$(".topic_edit_save").hide(); $(".topic_edit_save").hide();
$(".topic_edit_cancel").hide(); $(".topic_edit_cancel").hide();
$(".topic_edit_spinner").show();
}; };
exports.hide_topic_move_spinner = function () { exports.hide_topic_move_spinner = function () {
@@ -549,6 +550,7 @@ exports.start_topic_edit = function (recipient_row) {
const form = $(render_topic_edit_form()); const form = $(render_topic_edit_form());
current_msg_list.show_edit_topic_on_recipient_row(recipient_row, form); current_msg_list.show_edit_topic_on_recipient_row(recipient_row, form);
form.on("keydown", handle_inline_topic_edit_keydown); form.on("keydown", handle_inline_topic_edit_keydown);
$(".topic_edit_spinner").hide();
const msg_id = rows.id_for_recipient_row(recipient_row); const msg_id = rows.id_for_recipient_row(recipient_row);
const message = current_msg_list.get(msg_id); const message = current_msg_list.get(msg_id);
let topic = message.topic; let topic = message.topic;