paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_row: Shrink sender_info_hover region.

Browse Source 
The sender_info_hover region incorrectly filled the full row to the
right of the sender's name, resulting in the blue highlight being
visible in parts of the message that should be just the message body.

Fix this by moving the selectors for it further down in the DOM.

Fixes #25276.
This commit is contained in:
Tim Abbott
2023-04-27 10:52:56 -07:00
parent 866c91d5a5
commit ab0c5f3092
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/templates/me_message.hbs
View File

@@ -1,8 +1,6 @@
<span class="message_sender no-select is_me_message">
<span class="sender_info_hover">
<span>
{{> message_avatar}}
</span>
<span>
{{> message_avatar}}
</span>
<span class="sender-status">

2
web/templates/message_avatar.hbs
View File

@@ -1,4 +1,4 @@
<div class="u-{{msg/sender_id}} inline_profile_picture {{#sender_is_guest}} guest-avatar{{/sender_is_guest}} view_user_card_tooltip" aria-hidden="true">
<div class="u-{{msg/sender_id}} sender_info_hover inline_profile_picture {{#sender_is_guest}} guest-avatar{{/sender_is_guest}} view_user_card_tooltip" aria-hidden="true">
<img src="{{small_avatar_url}}" alt="" class="no-drag"/>
</div>
{{~! remove whitespace ~}}

4
web/templates/message_body.hbs
View File

@@ -1,9 +1,9 @@
{{#unless status_message}}
<span class="message_sender sender_info_hover no-select">
<span class="message_sender no-select">
{{#if include_sender}}
<span>
{{> message_avatar ~}}
<span class="sender_name auto-select" role="button" tabindex="0">
<span class="sender_info_hover sender_name auto-select" role="button" tabindex="0">
<span class="sender_name_padding view_user_card_tooltip"></span>
<span class="view_user_card_tooltip">{{msg/sender_full_name}}{{> status_emoji msg/status_emoji_info}}</span>
</span>