gocd: Strengthen types using WildValue.

zerver/webhooks/gocd/view.py

@@ -1,13 +1,13 @@
 # Webhooks for external integrations.
 import json
 import os
-from typing import Any, Dict
 
 from django.http import HttpRequest, HttpResponse
 
 from zerver.decorator import webhook_view
 from zerver.lib.request import REQ, has_request_variables
 from zerver.lib.response import json_success
+from zerver.lib.validator import WildValue, check_string, to_wild_value
 from zerver.lib.webhooks.common import check_send_webhook_message
 from zerver.models import UserProfile
 
@@ -23,11 +23,11 @@ Comment: {}"""
 def api_gocd_webhook(
     request: HttpRequest,
     user_profile: UserProfile,
-    payload: Dict[str, Any] = REQ(argument_type="body"),
+    payload: WildValue = REQ(argument_type="body", converter=to_wild_value),
 ) -> HttpResponse:
 
     modifications = payload["build_cause"]["material_revisions"][0]["modifications"][0]
-    result = payload["stages"][0]["result"]
+    result = payload["stages"][0]["result"].tame(check_string)
     material = payload["build_cause"]["material_revisions"][0]["material"]
 
     if result == "Passed":
@@ -42,13 +42,13 @@ def api_gocd_webhook(
         build_link = contents["build_details"]["_links"]["pipeline"]["href"]
 
     body = MESSAGE_TEMPLATE.format(
-        modifications["user_name"],
+        modifications["user_name"].tame(check_string),
         result,
         emoji,
         build_link,
-        modifications["comment"],
+        modifications["comment"].tame(check_string),
     )
-    branch = material["description"].split(",")
+    branch = material["description"].tame(check_string).split(",")
     topic = branch[0].split(" ")[1]
 
     check_send_webhook_message(request, user_profile, topic, body)