paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

gocd: Strengthen types using WildValue.

Browse Source
This commit is contained in:
Hari Prashant Bhimaraju
2022-10-08 23:52:51 +05:30
committed by Tim Abbott
parent 2bd1093c38
commit ac1a38db75
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/webhooks/gocd/view.py
View File

@@ -1,13 +1,13 @@
# Webhooks for external integrations. # Webhooks for external integrations.
import json import json
import os import os
from typing import Any, Dict
from django.http import HttpRequest, HttpResponse from django.http import HttpRequest, HttpResponse
from zerver.decorator import webhook_view from zerver.decorator import webhook_view
from zerver.lib.request import REQ, has_request_variables from zerver.lib.request import REQ, has_request_variables
from zerver.lib.response import json_success from zerver.lib.response import json_success
from zerver.lib.validator import WildValue, check_string, to_wild_value
from zerver.lib.webhooks.common import check_send_webhook_message from zerver.lib.webhooks.common import check_send_webhook_message
from zerver.models import UserProfile from zerver.models import UserProfile
@@ -23,11 +23,11 @@ Comment: {}"""
def api_gocd_webhook( def api_gocd_webhook(
request: HttpRequest, request: HttpRequest,
user_profile: UserProfile, user_profile: UserProfile,
payload: Dict[str, Any] = REQ(argument_type="body"), payload: WildValue = REQ(argument_type="body", converter=to_wild_value),
) -> HttpResponse: ) -> HttpResponse:
modifications = payload["build_cause"]["material_revisions"][0]["modifications"][0] modifications = payload["build_cause"]["material_revisions"][0]["modifications"][0]
result = payload["stages"][0]["result"] result = payload["stages"][0]["result"].tame(check_string)
material = payload["build_cause"]["material_revisions"][0]["material"] material = payload["build_cause"]["material_revisions"][0]["material"]
if result == "Passed": if result == "Passed":
@@ -42,13 +42,13 @@ def api_gocd_webhook(
build_link = contents["build_details"]["_links"]["pipeline"]["href"] build_link = contents["build_details"]["_links"]["pipeline"]["href"]
body = MESSAGE_TEMPLATE.format( body = MESSAGE_TEMPLATE.format(
modifications["user_name"], modifications["user_name"].tame(check_string),
result, result,
emoji, emoji,
build_link, build_link,
modifications["comment"], modifications["comment"].tame(check_string),
) )
branch = material["description"].split(",") branch = material["description"].tame(check_string).split(",")
topic = branch[0].split(" ")[1] topic = branch[0].split(" ")[1]
check_send_webhook_message(request, user_profile, topic, body) check_send_webhook_message(request, user_profile, topic, body)