paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotkey.js: Simplify ctrl+[ hotkey logic.

Browse Source
This commit is contained in:
Joshua Pan
2017-09-18 16:33:17 -07:00
committed by Tim Abbott
parent d387291b6c
commit b201e2c311
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/hotkey.js
View File

@@ -99,7 +99,7 @@ function stubbing(func_name_to_stub, test_function) {
assert.equal(map_press(47).name, 'search'); // slash
assert.equal(map_press(106).name, 'vim_down'); // j
assert.equal(map_down(219, false, true).name, 'esc_ctrl');
assert.equal(map_down(219, false, true).name, 'escape');
// More negative tests.
assert.equal(map_down(47), undefined);

4
static/js/hotkey.js
View File

@@ -41,7 +41,7 @@ var keydown_unshift_mappings = {
};
var keydown_ctrl_mappings = {
219: {name: 'esc_ctrl', message_view_only: false}, // '['
219: {name: 'escape', message_view_only: false}, // '['
};
var keydown_either_mappings = {
@@ -398,8 +398,6 @@ exports.process_hotkey = function (e, hotkey) {
return exports.process_tab_key();
case 'shift_tab':
return exports.process_shift_tab_key();
case 'esc_ctrl':
return exports.process_escape_key(e);
}
switch (event_name) {