paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 08:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

css: Rename #home id to #message_feed_container.

Browse Source
This commit is contained in:
Aman Agrawal
2020-07-04 19:55:41 +05:30
committed by Tim Abbott
parent 0859a91b14
commit b34d46e00b
12 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend_tests/node_tests/hashchange.js
View File

@@ -159,7 +159,7 @@ run_test("hash_interactions", () => {
helper.assert_events([
"overlays.close_for_hash_change",
"message_viewport.stop_auto_scrolling",
"change_tab_to #home",
"change_tab_to #message_feed_container",
"narrow.deactivate",
"floating_recipient_bar.update",
]);
@@ -169,7 +169,7 @@ run_test("hash_interactions", () => {
helper.assert_events([
"overlays.close_for_hash_change",
"message_viewport.stop_auto_scrolling",
"change_tab_to #home",
"change_tab_to #message_feed_container",
"narrow.deactivate",
"floating_recipient_bar.update",
]);
@@ -181,7 +181,7 @@ run_test("hash_interactions", () => {
helper.assert_events([
"overlays.close_for_hash_change",
"message_viewport.stop_auto_scrolling",
"change_tab_to #home",
"change_tab_to #message_feed_container",
"narrow.activate",
"floating_recipient_bar.update",
]);
@@ -195,7 +195,7 @@ run_test("hash_interactions", () => {
helper.assert_events([
"overlays.close_for_hash_change",
"message_viewport.stop_auto_scrolling",
"change_tab_to #home",
"change_tab_to #message_feed_container",
"narrow.activate",
"floating_recipient_bar.update",
]);

6
static/js/click_handlers.js
View File

@@ -269,7 +269,7 @@ exports.initialize = function () {
$("body").on("click", ".notification", function () {
const payload = $(this).data("narrow");
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
narrow.activate(payload.raw_operators, payload.opts_notif);
});
@@ -452,7 +452,7 @@ exports.initialize = function () {
return nearest.id;
}
$("#home").on("click", ".narrows_by_recipient", function (e) {
$("#message_feed_container").on("click", ".narrows_by_recipient", function (e) {
if (e.metaKey || e.ctrlKey) {
return;
}
@@ -461,7 +461,7 @@ exports.initialize = function () {
narrow.by_recipient(row_id, {trigger: "message header"});
});
$("#home").on("click", ".narrows_by_topic", function (e) {
$("#message_feed_container").on("click", ".narrows_by_topic", function (e) {
if (e.metaKey || e.ctrlKey) {
return;
}

2
static/js/compose_actions.js
View File

@@ -112,7 +112,7 @@ exports.complete_starting_tasks = function (msg_type, opts) {
// makes testing a bit easier.
exports.maybe_scroll_up_selected_message();
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
compose_fade.start_compose(msg_type);
ui_util.decorate_stream_bar(opts.stream, $("#stream-message .message_header_stream"), true);
$(document).trigger($.Event("compose_started.zulip", opts));

4
static/js/condense.js
View File

@@ -234,7 +234,7 @@ exports.condense_and_collapse = function (elems) {
};
exports.initialize = function () {
$("#home").on("click", ".message_expander", function (e) {
$("#message_feed_container").on("click", ".message_expander", function (e) {
// Expanding a message can mean either uncollapsing or
// uncondensing it.
const row = $(this).closest(".message_row");
@@ -254,7 +254,7 @@ exports.initialize = function () {
e.preventDefault();
});
$("#home").on("click", ".message_condenser", function (e) {
$("#message_feed_container").on("click", ".message_condenser", function (e) {
const row = $(this).closest(".message_row");
current_msg_list.get(rows.id(row)).condensed = true;
condense_row(row);

4
static/js/gear_menu.js
View File

@@ -98,7 +98,7 @@ exports.initialize = function () {
// Set the URL bar title to show the sub-page you're currently on.
let browser_url = target_tab;
if (browser_url === "#home") {
if (browser_url === "#message_feed_container") {
browser_url = "";
}
hashchange.changehash(browser_url);
@@ -106,7 +106,7 @@ exports.initialize = function () {
// After we show the new tab, restore its old scroll position
// (we apparently have to do this after setting the hash,
// because otherwise that action may scroll us somewhere.)
if (target_tab === "#home") {
if (target_tab === "#message_feed_container") {
if (scroll_positions.has(target_tab)) {
message_viewport.scrollTop(scroll_positions.get(target_tab));
} else {

4
static/js/hashchange.js
View File

@@ -49,7 +49,7 @@ exports.save_narrow = function (operators) {
};
function activate_home_tab() {
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
narrow.deactivate();
floating_recipient_bar.update();
search.update_button_visibility();
@@ -92,7 +92,7 @@ function do_hashchange_normal(from_reload) {
const hash = window.location.hash.split("/");
switch (hash[0]) {
case "#narrow": {
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
const operators = hash_util.parse_narrow(hash);
if (operators === undefined) {
// If the narrow URL didn't parse, clear

2
static/js/message_scroll.js
View File

@@ -115,7 +115,7 @@ exports.actively_scrolling = function () {
exports.scroll_finished = function () {
actively_scrolling = false;
if (!$("#home").hasClass("active")) {
if (!$("#message_feed_container").hasClass("active")) {
return;
}

2
static/js/narrow.js
View File

@@ -261,7 +261,7 @@ exports.activate = function (raw_operators, opts) {
$("#zfilt").addClass("focused_table");
$("#zhome").removeClass("focused_table");
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
message_list.set_narrowed(msg_list);
current_msg_list = message_list.narrowed;

2
static/js/search.js
View File

@@ -9,7 +9,7 @@ exports.narrow_or_search_for_term = function (search_string) {
// while using input tool
return search_query_box.val();
}
ui_util.change_tab_to("#home");
ui_util.change_tab_to("#message_feed_container");
let operators;
if (page_params.search_pills_enabled) {

2
static/styles/zulip.scss
View File

@@ -2399,7 +2399,7 @@ div.topic_edit_spinner .loading_indicator_spinner {
margin-left: -15px;
}
#home {
#message_feed_container {
margin-top: 41px;
}

2
templates/zerver/app/index.html
View File

@@ -94,7 +94,7 @@
</div>
<div class="column-middle">
<div class="column-middle-inner tab-content">
<div class="tab-pane active" id="home">
<div class="tab-pane active" id="message_feed_container">
<div class="fixed-app" id="floating_recipient_bar">
<div class="app-main recipient_bar_content">
<div class="column-middle column-overlay recipient-bar-main">

2
templates/zerver/app/navbar.html
View File

@@ -59,7 +59,7 @@
view is a Bootstrap Nav tab, even though we don't show the tab
anymore
#}
<li class="invisible" style="display:none;" role="presentation"><a href="#home" data-toggle="tab"></a></li>
<li class="invisible" style="display:none;" role="presentation"><a href="#message_feed_container" data-toggle="tab"></a></li>
<li role="presentation">
<a href="#streams/subscribed" role="menuitem">
<i class="fa fa-exchange" aria-hidden="true"></i> {{ _('Manage streams') }}