mirror of
https://github.com/zulip/zulip.git
synced 2025-11-01 12:33:40 +00:00
reactions: Downgrade blueslip error to a warning.
When we get a server error for adding/removing a reaction, we no longer make a blueslip error, since it is somewhat common for users to retry actions before the server sends an event. The code comment that is part of this commit explains this further. Fixes #4290.
This commit is contained in:
@@ -12,7 +12,12 @@ function send_reaction_ajax(message_id, emoji_name, operation) {
|
||||
success: function () {},
|
||||
error: function (xhr) {
|
||||
var response = channel.xhr_error_message("Error sending reaction", xhr);
|
||||
blueslip.error(response);
|
||||
// Errors are somewhat commmon here, due to race conditions
|
||||
// where the user tries to add/remove the reaction when there is already
|
||||
// an in-flight request. We eventually want to make this a blueslip
|
||||
// error, rather than a warning, but we need to implement either
|
||||
// #4291 or #4295 first.
|
||||
blueslip.warn(response);
|
||||
},
|
||||
};
|
||||
if (operation === 'add') {
|
||||
|
Reference in New Issue
Block a user