paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

server_settings: Use a reasonable default when User-Agent not specified.

Browse Source 
Apparently, some Zulip clients don't send a User-Agent in their
requests to /server_settings, and this makes that not 500.
This commit is contained in:
Tim Abbott
2018-12-11 11:29:25 -08:00
parent 2a39852e91
commit b7127a395b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/views/auth.py
View File

@@ -845,7 +845,7 @@ def api_get_auth_backends(request: HttpRequest) -> HttpResponse:
return json_success(auth_backends) return json_success(auth_backends)
def check_server_incompatibility(request: HttpRequest) -> bool: def check_server_incompatibility(request: HttpRequest) -> bool:
user_agent = parse_user_agent(request.META["HTTP_USER_AGENT"]) user_agent = parse_user_agent(request.META.get("HTTP_USER_AGENT", "Missing User-Agent"))
return user_agent['name'] == "ZulipInvalid" return user_agent['name'] == "ZulipInvalid"
@require_GET @require_GET