paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 10:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change edit_message_content to have unique IDs for different messages.

Browse Source 
Fixes bugs of when multiple messages are being edited simultaneously.
Specifically, typeahead is no longer broken, copying messages to clipboard
is less buggy, and resizing is no longer
broken when multiple messages are being edited.
This commit is contained in:
Cory Lynch
2017-04-25 23:14:33 -04:00
committed by Tim Abbott
parent 81a575e4d5
commit ba7b7a9a36
4 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/message_edit.js
View File

@@ -183,6 +183,7 @@ function edit_message(row, raw_content) {
var form = $(templates.render(
'message_edit_form',
{is_stream: (message.type === 'stream'),
message_id: message.id,
is_editable: is_editable,
has_been_editable: (editability !== editability_types.NO),
topic: message.subject,
@@ -220,9 +221,10 @@ function edit_message(row, raw_content) {
initClipboard(copy_message[0]);
} else if (editability === editability_types.FULL) {
copy_message.remove();
var listeners = resize.watch_manual_resize("#message_edit_content");
var edit_id = "#message_edit_content_" + rows.id(row);
var listeners = resize.watch_manual_resize(edit_id);
currently_editing_messages[rows.id(row)].listeners = listeners;
composebox_typeahead.initialize_compose_typeahead("#message_edit_content", {emoji: true, stream: true});
composebox_typeahead.initialize_compose_typeahead(edit_id, {emoji: true, stream: true});
}
// Add tooltip
@@ -364,7 +366,7 @@ exports.end = function (row) {
// Clean up resize event listeners
var listeners = currently_editing_messages[message.id].listeners;
var edit_box = document.querySelector("#message_edit_content");
var edit_box = document.querySelector("#message_edit_content_" + message.id);
edit_box.removeEventListener("mousedown", listeners[0]);
document.body.removeEventListener("mouseup", listeners[1]);