paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 11:33:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

node tests: Clean up emoji tests.

Browse Source 
A few things here:

    * Use _.each to follow our convention.
    * Just use new locals to avoid overwriting template and
      avoid strange Object.assign hack.
    * Just use simple string concatenation.
    * Use better var names: full_name, shortcut
    * Use chaining syntax.
This commit is contained in:
Steve Howell
2018-04-12 20:23:50 +00:00
committed by Tim Abbott
parent 07591f03e2
commit c1a3c85a33
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
frontend_tests/node_tests/emoji.js
View File

@@ -99,15 +99,16 @@ zrequire('util');
{name: 'between symbols', original: 'Hello.<original>! World.', expected: 'Hello.<original>! World.'},
{name: 'before end of sentence', original: 'Hello <original>!', expected: 'Hello <converted>!'},
];
Object.keys(emoji.EMOTICON_CONVERSIONS).forEach(key => {
testcases.forEach(t => {
var converted_value = `:${emoji.EMOTICON_CONVERSIONS[key]}:`;
t = Object.assign({}, t); // circumvent copy by reference.
t.original = t.original.replace(/(<original>)/g, key);
t.expected = t.expected.replace(/(<original>)/g, key);
t.expected = t.expected.replace(/(<converted>)/g, converted_value);
var result = emoji.translate_emoticons_to_names(t.original);
assert.equal(result, t.expected);
_.each(emoji.EMOTICON_CONVERSIONS, (full_name, shortcut) => {
_.each(testcases, (t) => {
var converted_value = ':' + full_name + ':';
var original = t.original;
var expected = t.expected;
original = original.replace(/(<original>)/g, shortcut);
expected = expected.replace(/(<original>)/g, shortcut)
.replace(/(<converted>)/g, converted_value);
var result = emoji.translate_emoticons_to_names(original);
assert.equal(result, expected);
});
});
}());