paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

postprocess: Access data- attributes directly.

Browse Source 
This makes for much easier grepping of these values
across the codebase, especially for squaring server-
side processing and tests.
This commit is contained in:
Karl Stolley
2025-09-26 11:22:40 -04:00
committed by Tim Abbott
parent b7b409002e
commit c609b55950
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/postprocess_content.ts
View File

@@ -178,7 +178,8 @@ export function postprocess_content(html: string): string {
image_url.pathname.startsWith("/user_uploads/thumbnail/")
) {
let thumbnail_name = thumbnail.preferred_format.name;
if (message_media_image.dataset.animated === "true") {
// eslint-disable-next-line unicorn/prefer-dom-node-dataset
if (message_media_image.getAttribute("data-animated") === "true") {
if (
user_settings.web_animate_image_previews === "always" ||
// Treat on_hover as "always" on mobile web, where
@@ -208,7 +209,10 @@ export function postprocess_content(html: string): string {
// set those values as `height` and `width` attributes on the
// image source.
if (message_media_image?.hasAttribute("data-original-dimensions")) {
const original_dimensions_attribute = message_media_image.dataset.originalDimensions;
// eslint-disable-next-line unicorn/prefer-dom-node-dataset
const original_dimensions_attribute = message_media_image.getAttribute(
"data-original-dimensions",
);
assert(original_dimensions_attribute);
const original_dimensions: string[] = original_dimensions_attribute.split("x");
assert(