paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

mime_types: Remove incorrect comment, and add audio/mp4 and audio/webm.

Browse Source 
The comment came from when the only use of `AUDIO_INLINE_MIME_TYPES`
was based on the result of `mimetypes.guess_type`, which would happen
to always return `video/mp4` and not of `audio/mp4` for `.mp4` files.
Before being merged, the code was updated to examine uploaded files'
content-type, which can very well be `audio/mp4` -- and in such cases,
should very much be shown inline.

Add the missing content-types to `AUDIO_INLINE_MIME_TYPES`, and remove
the comment.
This commit is contained in:
Alex Vandiver
2025-07-16 03:17:08 +00:00
committed by Tim Abbott
parent f87479703d
commit c977730f81
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/mime_types.py
View File

@@ -25,19 +25,15 @@ for mime_type, extension in EXTRA_MIME_TYPES:
AUDIO_INLINE_MIME_TYPES = [
"audio/aac",
"audio/flac",
"audio/mp4",
"audio/mpeg",
"audio/wav",
"audio/webm",
]
INLINE_MIME_TYPES = [
*AUDIO_INLINE_MIME_TYPES,
"application/pdf",
# We don't want to include `audio/mp4` and `audio/webm` in the
# `AUDIO_INLINE_MIME` TYPES because despite their ability to be
# used for both audio and video, they happen to be parsed only
# in their video form.
"audio/mp4",
"audio/webm",
"image/apng",
"image/avif",
"image/gif",