paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

outgoing_webhook: Fix strict_optional errors.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-07-04 17:32:47 -07:00
committed by Tim Abbott
parent e3fc74fd20
commit d64f036247
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mypy.ini
View File

@@ -40,8 +40,6 @@ strict_optional = True
# General exclusions to work on
[mypy-zerver.lib.outgoing_webhook]
strict_optional = False
[mypy-zerver.lib.markdown] # for __init__.py
strict_optional = False
[mypy-zerver.lib.push_notifications]

5
zerver/lib/outgoing_webhook.py
View File

@@ -143,7 +143,7 @@ AVAILABLE_OUTGOING_WEBHOOK_INTERFACES: Dict[str, Any] = {
}
def get_service_interface_class(interface: str) -> Any:
if interface is None or interface not in AVAILABLE_OUTGOING_WEBHOOK_INTERFACES:
if interface not in AVAILABLE_OUTGOING_WEBHOOK_INTERFACES:
return AVAILABLE_OUTGOING_WEBHOOK_INTERFACES[GENERIC_INTERFACE]
else:
return AVAILABLE_OUTGOING_WEBHOOK_INTERFACES[interface]
@@ -172,7 +172,7 @@ def send_response_message(bot_id: int, message_info: Dict[str, Any], response_da
message_type = message_info['type']
display_recipient = message_info['display_recipient']
try:
topic_name = get_topic_from_message_info(message_info)
topic_name: Optional[str] = get_topic_from_message_info(message_info)
except KeyError:
topic_name = None
@@ -228,6 +228,7 @@ def notify_bot_owner(event: Dict[str, Any],
message_url = get_message_url(event)
bot_id = event['user_profile_id']
bot_owner = get_user_profile_by_id(bot_id).bot_owner
assert bot_owner is not None
notification_message = f"[A message]({message_url}) triggered an outgoing webhook."
if failure_message: