paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications: Refactor update_notification_sound_source.

Browse Source 
The container element and settings object are passed as
parameters to update_notification_sound_source. This change
is done so that we can use the same function for updating
the realm-level notification sound source.
This commit is contained in:
Sahil Batra
2021-08-30 22:21:30 +05:30
committed by Tim Abbott
parent 079e45c7cf
commit de1aa25059
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/notifications.js
View File

@@ -89,13 +89,12 @@ export function initialize() {
window_focused = false;
});
update_notification_sound_source();
update_notification_sound_source($("#user-notification-sound-audio"), user_settings);
}
function update_notification_sound_source() {
const notification_sound = user_settings.notification_sound;
function update_notification_sound_source(container_elem, settings_object) {
const notification_sound = settings_object.notification_sound;
const audio_file_without_extension = "/static/audio/notification_sounds/" + notification_sound;
const container_elem = $("#user-notification-sound-audio");
container_elem
.find(".notification-sound-source-ogg")
.attr("src", `${audio_file_without_extension}.ogg`);
@@ -739,6 +738,6 @@ export function handle_global_notification_updates(notification_name, setting) {
if (notification_name === "notification_sound") {
// Change the sound source with the new page `notification_sound`.
update_notification_sound_source();
update_notification_sound_source($("#user-notification-sound-audio"), user_settings);
}
}