paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

drafts: Don't save drafts with 2 or less characters.

Browse Source 
Fixes #10357.
This commit is contained in:
Joshua Pan
2018-08-21 17:04:30 -04:00
committed by Tim Abbott
parent 4318f75718
commit eca4266cde
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/node_tests/drafts.js
View File

@@ -71,6 +71,12 @@ var draft_2 = {
type: "private",
content: "Test Private Message",
};
var short_msg = {
stream: "stream",
subject: "topic",
type: "stream",
content: "a",
};
run_test('draft_model', () => {
var draft_model = drafts.draft_model;
@@ -152,6 +158,9 @@ run_test('snapshot_message', () => {
stub_draft(draft_2);
assert.deepEqual(drafts.snapshot_message(), draft_2);
stub_draft(short_msg);
assert.deepEqual(drafts.snapshot_message(), undefined);
stub_draft({});
assert.equal(drafts.snapshot_message(), undefined);
});

4
static/js/drafts.js
View File

@@ -64,9 +64,9 @@ var draft_model = (function () {
exports.draft_model = draft_model;
exports.snapshot_message = function () {
if (!compose_state.composing() || compose_state.message_content() === "") {
if (!compose_state.composing() || compose_state.message_content().length <= 2) {
// If you aren't in the middle of composing the body of a
// message, don't try to snapshot.
// message or the message is shorter than 2 characters long, don't try to snapshot.
return;
}