paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

subs: Use scroll_util to move selected stream rows into view.

Browse Source 
This eliminates a bunch of complex logic we previously used when
trying to make keyboard stream row navigation smoother.
This commit is contained in:
Cynthia Lin
2018-07-22 20:34:19 -07:00
committed by Tim Abbott
parent 8304f0dbec
commit ee82f14d04
1 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
static/js/subs.js
View File

@@ -573,29 +573,11 @@ exports.change_state = (function () {
// if the first argument is a valid number.
} else if (/\d+/.test(hash.arguments[0])) {
var stream_row = row_for_stream_id(hash.arguments[0]);
var streams_list = $(".streams-list")[0];
get_active_data().row.removeClass("active");
stream_row.addClass("active");
if ($(".stream-row:not(.notdisplayed):first")[0] === stream_row[0]) {
streams_list.scrollTop = 0;
}
if ($(".stream-row:not(.notdisplayed):last")[0] === stream_row[0]) {
streams_list.scrollTop = streams_list.scrollHeight - $(".streams-list").height();
}
if (stream_row.position().top < 70) {
streams_list.scrollTop -= streams_list.clientHeight / 2;
}
var dist_from_top = stream_row.position().top;
var total_dist = dist_from_top + stream_row[0].clientHeight;
var dist_from_bottom = streams_list.clientHeight - total_dist;
if (dist_from_bottom < -4) {
streams_list.scrollTop += streams_list.clientHeight / 2;
}
scroll_util.scroll_element_into_container(stream_row, stream_row.parent());
setTimeout(function () {
if (hash.arguments[0] === get_active_data().id) {