paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

message scrolling: Add visible_bottom to info.

Browse Source 
It's convenient to have visible_bottom as well
as top/height, and the extra computation is
trivial (it's just arithmetic, no extra jQuery
involved).

There's some minor cleanup here too.
This commit is contained in:
Steve Howell
2019-01-06 16:29:14 +00:00
committed by Tim Abbott
parent 6c3bb507b0
commit f1f7f72119
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/message_viewport.js
View File

@@ -26,15 +26,14 @@ exports.message_viewport_info = function () {
var res = {};
var element_just_above_us = $(".floating_recipient");
var element_just_below_us = $("#compose");
res.visible_top = element_just_above_us.offset().top
+ element_just_above_us.safeOuterHeight();
var element_just_below_us = $("#compose");
res.visible_bottom = element_just_below_us.position().top;
res.visible_height =
element_just_below_us.position().top
- res.visible_top;
res.visible_height = res.visible_bottom - res.visible_top;
return res;
};
@@ -288,7 +287,7 @@ exports.recenter_view = function (message, opts) {
var viewport_info = exports.message_viewport_info();
var top_threshold = viewport_info.visible_top;
var bottom_threshold = viewport_info.visible_top + viewport_info.visible_height;
var bottom_threshold = viewport_info.visible_bottom;
var message_top = message.offset().top;
var message_height = message.safeOuterHeight(true);