paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-25 17:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hide rerender_message and use rerender_messages() in all cases.

Browse Source 
rerender_messages() does extra work such as making rerendering in narrows
safe, as well as updating recipient bars. That should be the only valid entry
point for rerendering individual messages

(imported from commit f91aeb2070b1056ab95e01d68a342558c2813ae8)
This commit is contained in:
Leo Franchi
2014-03-04 10:47:44 -05:00
parent ca031304b9
commit f2e8929b8a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/echo.js
View File

@@ -191,9 +191,9 @@ exports.edit_locally = function edit_locally(message, raw_content, new_topic) {
message.content = exports.apply_markdown(raw_content);
// We don't handle unread counts since local messages must be sent by us
home_msg_list.view.rerender_message(message);
home_msg_list.view.rerender_messages([message]);
if (current_msg_list === narrowed_msg_list) {
narrowed_msg_list.view.rerender_message(message);
narrowed_msg_list.view.rerender_messages([message]);
}
stream_list.update_streams_sidebar();
};

4
static/js/message_list_view.js
View File

@@ -599,7 +599,7 @@ MessageListView.prototype = {
header.replaceWith(rendered_recipient_row);
},
rerender_message: function MessageListView__rerender_message(message) {
_rerender_message: function MessageListView___rerender_message(message) {
var row = this.get_row(message.id);
var was_selected = this.list.selected_message() === message;
@@ -640,7 +640,7 @@ MessageListView.prototype = {
message_groups.push(current_group);
current_group = [];
}
self.rerender_message(message);
self._rerender_message(message);
});
if (current_group.length !== 0) {
message_groups.push(current_group);