paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

linter: Remove unnecessary escape sequences in custom rules.

Browse Source
This commit is contained in:
Robert Hönig
2017-09-27 09:47:46 +02:00
committed by Tim Abbott
parent 48696ac9a1
commit fa8199819c
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/linter_lib/custom_check.py
View File

@@ -213,7 +213,7 @@ def build_custom_checkers(by_lang):
'description': 'Missing whitespace after ":"'}, 'description': 'Missing whitespace after ":"'},
{'pattern': "':\w[^']*$", {'pattern': "':\w[^']*$",
'description': 'Missing whitespace after ":"'}, 'description': 'Missing whitespace after ":"'},
{'pattern': "^\s+[#]\w", {'pattern': "^\s+#\w",
'strip': '\n', 'strip': '\n',
'description': 'Missing whitespace after "#"'}, 'description': 'Missing whitespace after "#"'},
{'pattern': "assertEquals[(]", {'pattern': "assertEquals[(]",
@@ -278,14 +278,14 @@ def build_custom_checkers(by_lang):
See WRAPPER_COMMENT in test_helpers.py for details. See WRAPPER_COMMENT in test_helpers.py for details.
'''}, '''},
# Directly fetching Message objects in e.g. views code is often a security bug. # Directly fetching Message objects in e.g. views code is often a security bug.
{'pattern': '[^r][M]essage.objects.get', {'pattern': '[^r]Message.objects.get',
'exclude': set(["zerver/tests", 'exclude': set(["zerver/tests",
"zerver/lib/onboarding.py", "zerver/lib/onboarding.py",
"zilencer/management/commands/add_mock_conversation.py", "zilencer/management/commands/add_mock_conversation.py",
"zerver/worker/queue_processors.py"]), "zerver/worker/queue_processors.py"]),
'description': 'Please use access_message() to fetch Message objects', 'description': 'Please use access_message() to fetch Message objects',
}, },
{'pattern': '[S]tream.objects.get', {'pattern': 'Stream.objects.get',
'include_only': set(["zerver/views/"]), 'include_only': set(["zerver/views/"]),
'description': 'Please use access_stream_by_*() to fetch Stream objects', 'description': 'Please use access_stream_by_*() to fetch Stream objects',
}, },
@@ -303,7 +303,7 @@ def build_custom_checkers(by_lang):
]), ]),
'description': 'Please use access_stream_by_*() to fetch Stream objects', 'description': 'Please use access_stream_by_*() to fetch Stream objects',
}, },
{'pattern': '[S]tream.objects.filter', {'pattern': 'Stream.objects.filter',
'include_only': set(["zerver/views/"]), 'include_only': set(["zerver/views/"]),
'description': 'Please use access_stream_by_*() to fetch Stream objects', 'description': 'Please use access_stream_by_*() to fetch Stream objects',
}, },