paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

inline_topic_edit: Remove overflowing error text on saving empty topic.

Browse Source
This commit is contained in:
Sayam Samal
2025-02-13 04:28:28 +05:30
committed by Tim Abbott
parent 62bd5f36dc
commit faa08b6000
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/message_edit.ts
View File

@@ -1011,7 +1011,6 @@ export function try_save_inline_topic_edit($row: JQuery): void {
} }
export function do_save_inline_topic_edit($row: JQuery, message: Message, new_topic: string): void { export function do_save_inline_topic_edit($row: JQuery, message: Message, new_topic: string): void {
const msg_list = message_lists.current;
show_topic_edit_spinner($row); show_topic_edit_spinner($row);
if (message.locally_echoed) { if (message.locally_echoed) {
@@ -1074,13 +1073,6 @@ export function do_save_inline_topic_edit($row: JQuery, message: Message, new_to
return; return;
} }
loading.destroy_indicator($spinner); loading.destroy_indicator($spinner);
if (msg_list === message_lists.current) {
const message = channel.xhr_error_message(
$t({defaultMessage: "Error saving edit"}),
xhr,
);
$row.find(".edit_error").text(message).css("display", "inline-block");
}
}, },
}); });
} }

1
web/templates/topic_edit_form.hbs
View File

@@ -6,6 +6,5 @@
{{#unless realm_mandatory_topics}}placeholder="{{empty_string_topic_display_name}}"{{/unless}} /> {{#unless realm_mandatory_topics}}placeholder="{{empty_string_topic_display_name}}"{{/unless}} />
{{> components/icon_button squared=true custom_classes="topic_edit_save tippy-zulip-delayed-tooltip" icon="check" intent="brand" data-tooltip-template-id="save-button-tooltip-template" }} {{> components/icon_button squared=true custom_classes="topic_edit_save tippy-zulip-delayed-tooltip" icon="check" intent="brand" data-tooltip-template-id="save-button-tooltip-template" }}
{{> components/icon_button squared=true custom_classes="topic_edit_cancel tippy-zulip-delayed-tooltip" icon="circle-x" intent="neutral" data-tooltip-template-id="cancel-button-tooltip-template" }} {{> components/icon_button squared=true custom_classes="topic_edit_cancel tippy-zulip-delayed-tooltip" icon="circle-x" intent="neutral" data-tooltip-template-id="cancel-button-tooltip-template" }}
<div class="alert alert-error edit_error" style="display: none"></div>
<div class="topic_edit_spinner"></div> <div class="topic_edit_spinner"></div>
</form> </form>