paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

display_settings: Fix pencil being lost updating default language.

Browse Source 
The HTML was just done sloppily in the first version of this feature.
This commit is contained in:
Tim Abbott
2018-03-04 18:48:51 -08:00
parent 9acf30b3d3
commit fb340811a4
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/settings_display.js
View File

@@ -149,12 +149,11 @@ exports.report_emojiset_change = function () {
function _update_page() {
$("#twenty_four_hour_time").prop('checked', page_params.twenty_four_hour_time);
$("#left_side_userlist").prop('checked', page_params.left_side_userlist);
// TODO: We destroy the pencil when doing this
$("#default_language_name").text(page_params.default_language_name);
$("#translate_emoticons").prop('checked', page_params.translate_emoticons);
$("#night_mode").prop('checked', page_params.night_mode);
// TODO: Set emojiset selector here.
// Longer term, we'll want to automate
// Longer term, we'll want to automate this function
}
exports.update_page = function () {

4
static/templates/settings/display-settings.handlebars
View File

@@ -8,8 +8,8 @@
<div class="input-group user-name-section">
<label class="inline-block title">{{t "Default language" }}</label>
<a id="default_language" href="#default_language">
<button type="button" class="button rounded small inline-block" id='default_language_name'>
{{page_params.default_language_name}}
<button type="button" class="button rounded small inline-block">
<span id="default_language_name">{{page_params.default_language_name}}</span>
<i class="fa fa-pencil"></i>
</button>
</a>