paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 16:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

onboarding_steps: Fix abnormal initialize calling convention.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2025-06-13 17:35:51 -07:00
committed by Tim Abbott
parent 5ce55ac8f4
commit ff04cafc40
3 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/onboarding_steps.ts
View File

@@ -8,8 +8,9 @@ import * as blueslip from "./blueslip.ts";
import * as channel from "./channel.ts";
import * as dialog_widget from "./dialog_widget.ts";
import {$t, $t_html} from "./i18n.ts";
import type * as message_view from "./message_view.ts";
import * as people from "./people.ts";
import type {NarrowTerm, StateData, onboarding_step_schema} from "./state_data.ts";
import type {StateData, onboarding_step_schema} from "./state_data.ts";
import * as util from "./util.ts";
export type OnboardingStep = z.output<typeof onboarding_step_schema>;
@@ -56,7 +57,7 @@ export function update_onboarding_steps_to_display(onboarding_steps: OnboardingS
function narrow_to_dm_with_welcome_bot_new_user(
onboarding_steps: OnboardingStep[],
show_message_view: (raw_terms: NarrowTerm[], opts: {trigger: string}) => void,
show_message_view: typeof message_view.show,
): void {
if (
onboarding_steps.some(
@@ -168,10 +169,9 @@ function show_navigation_tour_video(navigation_tour_video_url: string | null): v
export function initialize(
params: StateData["onboarding_steps"],
navigation_tour_video_url: StateData["navigation_tour_video_url"],
show_message_view: (raw_terms: NarrowTerm[], opts: {trigger: string}) => void,
{show_message_view}: {show_message_view: typeof message_view.show},
): void {
update_onboarding_steps_to_display(params.onboarding_steps);
narrow_to_dm_with_welcome_bot_new_user(params.onboarding_steps, show_message_view);
show_navigation_tour_video(navigation_tour_video_url);
show_navigation_tour_video(params.navigation_tour_video_url);
}

5
web/src/state_data.ts
View File

@@ -580,10 +580,7 @@ export const state_data_schema = z
onboarding_steps: z.array(onboarding_step_schema),
navigation_tour_video_url: z.nullable(z.string()),
})
.transform(({onboarding_steps, navigation_tour_video_url}) => ({
onboarding_steps: {onboarding_steps},
navigation_tour_video_url,
})),
.transform((onboarding_steps) => ({onboarding_steps})),
)
.and(current_user_schema.transform((current_user) => ({current_user})))
.and(realm_schema.transform((realm) => ({realm})));

8
web/src/ui_init.js
View File

@@ -717,11 +717,9 @@ export async function initialize_everything(state_data) {
drafts_overlay_ui.initialize();
// This needs to happen after activity_ui.initialize, so that user_filter
// is defined. Also, must happen after people.initialize()
onboarding_steps.initialize(
state_data.onboarding_steps,
state_data.navigation_tour_video_url,
message_view.show,
);
onboarding_steps.initialize(state_data.onboarding_steps, {
show_message_view: message_view.show,
});
typing.initialize();
starred_messages_ui.initialize();
user_status_ui.initialize();