67046 Commits

Author SHA1 Message Date
Anders Kaseorg
33b8eabd9f message_flags: Fix type error.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
3ba68e7847 test_auth_backends: Fix _LDAPUser type errors.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
1d694aeff4 mypy: Fix no-redef errors from django-stubs.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
f24a0a6b81 ruff: Fix RUF059 Unpacked variable is never used.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
fa4d680851 ruff: Fix PYI059 Generic[] should always be the last base class.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
e9abaacd5c ruff: Fix PYI061 Use None rather than Literal[None].
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
0b400a66cc install-uv: Upgrade uv from 0.8.15 to 0.8.22.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:47:54 -07:00
Anders Kaseorg
7ebadb5d41 release-checklist: Prescribe docker build --pull.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-09-30 16:35:21 -07:00
Evy Kassirer
7167150a87 stream: Move subscriber_count to api_stream_schema. 2025-09-30 12:52:47 -07:00
Evy Kassirer
e9135cdc34 stream_data: Use clearer name for attrs for create_sub_from_server_data. 2025-09-30 12:52:47 -07:00
Evy Kassirer
06845359bd peer_data: Store subscriber counts off of the sub object. 2025-09-30 12:52:47 -07:00
Evy Kassirer
10a815cae7 stream_data: Rename add_sub to add_sub_for_tests. 2025-09-30 12:52:47 -07:00
Lauryn Menard
b4c63b73dc prod-template: Fix link for LDAP email sync unique ID. 2025-09-30 12:50:11 -07:00
Alya Abbott
f20035e2ad docs: Reorganize authentication backends documentation. 2025-09-30 12:50:11 -07:00
Evy Kassirer
665bce3c13 transmit: Pass params directly instead of using opts. 2025-09-30 11:49:16 -07:00
Evy Kassirer
53cbfb9086 compose: Rename request to more specific sent_message. 2025-09-30 11:49:16 -07:00
Evy Kassirer
240177b87e events: Use more realistic avatar_url in tests. 2025-09-30 11:49:16 -07:00
Evy Kassirer
1b9da1e3c7 transmit: Convert module to typescript. 2025-09-30 11:49:16 -07:00
Evy Kassirer
8a25069dd6 echo: Ensure avatar_url is defined when creating a local message.
`current_user.avatar_url` can be undefined, and we want to make
sure it's always defined here. Using `small_avatar_url_for_person`
returns the `person.avatar_url` if it is defined, but then properly
sets up and returns backup values if it's not.
2025-09-30 11:49:16 -07:00
Lauryn Menard
04275d8e14 docs: Rename "security-model.md" to "securing-your-zulip-server.md".
Updates relative links and any "security-model" label for ref links.
2025-09-30 11:41:06 -07:00
Sayam Samal
b894df61a4 drafts: Use span instead of em for placeholders without DM recipient.
The `em` tag is typically used to denote emphasis, which may not be
semantically appropriate for placeholder text, where we just want to
style the text as italic.
2025-09-30 11:37:16 -07:00
Sayam Samal
0d9e503add drafts: Add placeholder text for drafts with no channel selected.
This commit handles the empty channel placeholder for drafts saved
without a channel selected. When these drafts also do not have a topic,
we display "No topic selected" in tandem with "No channel selected",
since we are unable to access the channel configuration to determine
if we should display realm_empty_topic_display_name.
2025-09-30 11:37:16 -07:00
Lauryn Menard
91dde7cbeb help: Update mobile instructions for browse and subscribe to channels.
Update the mobile instructions for the new all channels view that
allows users to browse and subscribe to channels on the mobile app.
2025-09-30 11:27:49 -07:00
Lauryn Menard
692e907b68 help: Add mobile instructions for deleting a message completely. 2025-09-30 11:27:12 -07:00
Sahil Batra
e3fb292fb1 settings: Fix input field overflowing in channel and group edit UI.
Name input for stream and group edit modal was too wide in narrow
width screens and overflowed the modal. This commit adds CSS to
make sure that maximum width of input field is set to fit inside
the modal respecting the modal container paddings on narrow width
screens.

Fixes #35301.
2025-09-30 11:26:25 -07:00
Sahil Batra
31f8dcba6c settings: Improve label of can_set_topics_policy_group.
This commit updates the label for can_set_topics_policy_group
to specify that the user must be a channel administrator in
order to change the topics policy for a channel.

We did that before but it was removed in d8261d4b96.
2025-09-30 11:26:01 -07:00
Evy Kassirer
5b0f135497 stream_list: Fix inactive/muted count bug.
We shouldn't include muted topics from unmuted channels in the
inactive/muted toggle count, since those unreads aren't in the
inactive/muted section. This fixes that.

Reported here: https://github.com/zulip/zulip/issues/36011#issuecomment-3327042885
2025-09-29 15:14:00 -07:00
Lauryn Menard
06daab7174 api-docs: Add realm_can_delete_any_message_group content access note.
Users in this user group must also have content access to the message
in order to permanently delete it.
2025-09-29 11:06:40 -07:00
Lauryn Menard
b7815d9e2a api-docs: Update delete-messages description for current permissions.
Prior to feature level 281, the only users who had permissions to
permanently delete any message in the organization were organization
administrators.

Currently, various realm and channel permission settings, which use
the user group model, determine if a user is able to permanently
delete a specific message.

Updates the main description of the endpoint to note these settings
and removes the note that the endpoint is limited to organization
administrators.
2025-09-29 11:06:40 -07:00
Sahil Batra
d8261d4b96 settings: Improve label for can_set_topics_policy_group setting.
This commit updates the label for can_set_topics_policy_group
setting to be more clear by mentioning that it is used to
configure who can set the per-channel "general chat" configuration.

We also add a link to "/help/require-topics" with the label.
2025-09-29 11:00:26 -07:00
Karl Stolley
c609b55950 postprocess: Access data- attributes directly.
This makes for much easier grepping of these values
across the codebase, especially for squaring server-
side processing and tests.
2025-09-26 16:53:20 -07:00
Karl Stolley
b7b409002e postprocess: Set up new loop for message embeds. 2025-09-26 16:53:20 -07:00
Karl Stolley
31c49a7258 postprocess: Process YouTube images in image loop. 2025-09-26 16:53:20 -07:00
Karl Stolley
c7a651da60 postprocess: Handle images all within a single loop. 2025-09-26 16:53:20 -07:00
Karl Stolley
2e40359dd6 postprocess: Move refactored upload processing to own loop. 2025-09-26 16:53:20 -07:00
Karl Stolley
f9b52d4df5 postprocess: Move download processing nearer to links. 2025-09-26 16:53:20 -07:00
Karl Stolley
716333c6be postprocess: Move list-processing to the top.
This is the most simple loop, so sticking it at the top
keeps it from getting lost among the more complex
processing that follows.
2025-09-26 16:53:20 -07:00
Tim Abbott
e217340b23 help: Shorten title for apps link.
This avoids unnecessary line-wrapping, and I think sets expectations
correctly for anyone reading this sidebar.
2025-09-26 12:21:35 -07:00
Shubham Padia
f426936c6c help: Add external link icon as suffix in sidebar for external links.
Fixes https://chat.zulip.org/#narrow/channel/19-documentation/topic/left.20sidebar.20icon.20for.20external.20links.3F/with/2257078

These links should also open in a new window.
2025-09-26 12:20:55 -07:00
Shubham Padia
c3fbe00eb0 help: Add default page to display on /help when help server is off.
We've copied the button and error colors from portico_signin.css. We did
not want the new HTML file to depend on portico_signin.css since they
are unrelated. In addition, having those colors diverge over time might
not be an issue.

We make the raw mode work with /help and /help/ both.

See https://chat.zulip.org/#narrow/channel/19-documentation/topic/edits.20not.20appearing.20with.20vagrant/near/2257442

Co-authored-by: Alya Abbott <alya@zulip.com>
2025-09-26 11:41:10 -07:00
Shubham Padia
3b6d8de815 help: Rename --help-center to --help-center-static-build for run-dev.
Having it name --help-center made it sound like it was the default mode.
The new name reflects that option more accurately.
2025-09-26 11:18:26 -07:00
Shubham Padia
b79b068568 help: Add --only-help-center to run-dev.
The astro dev server takes a lot of memory and is disabled by default in
`run-dev`. We add another option to only run the dev server which is the
recommended mode for development. We still keep around the
`--help-center-dev-server` mode for folks who have machines with higher
specifications.

See https://chat.zulip.org/#narrow/channel/19-documentation/topic/edits.20not.20appearing.20with.20vagrant/near/2256856
2025-09-26 11:18:26 -07:00
Shubham Padia
8ddc7bee00 help: Make include a sibling of content/docs directory.
When moving content between the include files and the docs files while
copy pasting them, there was a need to change the imports everytime
this was done. This was inconvenient to do.

We considered path aliases to solve this problem but not all editors
support path resolution via those aliases and thus we change the
directory structure instead.

We change imports for components, include files and images in this
commit.

See
https://chat.zulip.org/#narrow/channel/19-documentation/topic/confused.20about.20include.20file
for more info.
2025-09-26 11:12:21 -07:00
Shubham Padia
3b1f4a9d09 help: Move static/images/help to starlight_help/src/images.
Astro was importing these images and doing it's own processing anyways,
there was not a reason for these images to stay in the static folder.

For channels-and-topics.png, we keep the help center directory as the
source directory for two symlinks since that is where the image is
likely to stay the longest.
2025-09-26 11:12:21 -07:00
Shubham Padia
50545d04db images: De-duplicate channels-and-topics.png.
The image is being duplicated across two places. We make the help
directory the source since it is more likely that an images of channels
and topics will stay in help (given that it has more information)
compared to the emails directory.
2025-09-26 11:12:21 -07:00
Alya Abbott
0ea04f31bc compose and feed: Improve label for DMs to yourself. 2025-09-26 11:07:48 -07:00
Aman Agrawal
8b8d23cc5f realm_redirect: Add help for self hosted users to login. 2025-09-26 11:02:26 -07:00
Lauryn Menard
05b2036acd narrow-banner: Update invalid "sender" case for empty narrow banner.
Updates the empty narrow banner for an invalid user in the "Messages
sent by ..." view to better match what we show for an unknown channel.
2025-09-26 10:16:19 -07:00
Lauryn Menard
52cad38f3e narrow-title: Use filter title for invalid "sender" operand case.
Since we have a generic title for the unknown user case for the
"sender" operator, we can now use that when we set the document
title for the narrow view.
2025-09-26 10:16:19 -07:00
Lauryn Menard
d82083ca24 filter: Add title for an unknown user for the "sender" narrow case.
Previously, the message header for the "Messages sent by" view for
an invalid or unknown user was the value of the "sender" operand,
which was not a valid/known user email.

Now we show a standard title in the message header for this case:
"Messages sent by unknown user".
2025-09-26 10:16:19 -07:00