It is possible for us to scroll user back to top of view if they
scroll before the render is complete and we haven't called
`revive_current_focus` yet.
This fixes it by wrapping the render and revive logic in a single
animation frame so that any scroll requests are delayed until we
have completed both of them.
This commit adds 'highlighted-element' class to <b> tags in
the following parts of the settings panel:
* who can access channel
* user member of a user group because of being part of a subgroup
already added.
'highlighted-element' class sets the 'font-weight: 600',
replacing the default of 700.
This commit adds 'highlighted-element' class to <b> tags in
the following compose banners:
* jump_to_sent_message_conversation_banner
* stream_does_not_exist_error
* unknown_zoom_user_error
* channel wildcard_mention_not_allowed_error
* topic wildcard_mention_not_allowed_error
'highlighted-element' class sets the 'font-weight: 600',
replacing the default of 700.
This commit adds 'highlighted-element' class to <b> tags in
the following left sidebar popovers:
* inbox
* combined feed
* recent conversations
'highlighted-element' class sets the 'font-weight: 600',
replacing the default of 700.
This commit adds 'highlighted-element' class to <b> tags in
the following confirm dialogs:
* delete topic
* mute user
* join user group
'highlighted-element' class sets the 'font-weight: 600',
replacing the default of 700.
We are porting the current help center docs to the new help center.
Porting the display_host variable to the new help center is a tricky
task and it is not worth to put in the effort for that just for 3 uses
of that variable.
This commit ensures that the focus on the topic list search box is only
triggered when the user clicks on the "SHOW ALL TOPICS" button, and not
when the narrow changes. This prevents unwanted focus behavior when
switching between different narrows/views which interfered with the
focus states of the compose box.
Fixes#20028.
There's no reason to have a special `RealmCreationKey` class - the
`Confirmation` system already does this job.
This is somewhat complicated by the need to write a migration for
`RealmCreationKey`->`Confirmation` for pre-existing, valid objects, to
avoid breaking realm creation links that haven't been used yet.
Clears up some naming confusion - `REALM_CREATION_LINK_VALIDITY_DAYS` is
a setting which describes the validaty period of RealmCreationKey, not
of Confirmation with REALM_CREATION type. Now that the latter is called
NEW_REALM_USER_REGISTRATION, there should be no confusion about this.
This commit refactors to import the full
`left_sidebar_navigation_area` module instead of
individual functions. This allows calling multiple
functions easily and prepares for upcoming navigation
view changes.
This commit adds 'highlighted-element' class to <b> tags in
the following onboarding modals:
* introduce inbox view modal
* introduce recent conversations view modal
* introduce resolve topic modal
* introduce first channel created modal
'highlighted-element' class sets the 'font-weight: 600',
replacing the default of 700.
We remove the ol > li margin rule to space out ordered list items since
that was the result of us overriding an upstream margin rule in
steps.css.
We inserted Steps inside include files only if they are not entirely
composed of an ordered list. If they are, they will eventually be
wrapped inside FlattenedSteps and wrapping these macros with Steps will
not give us the results we desire.
Using steps.css right now might feel like the more convenient way out,
but it might introduce friction in upgrades when the upstream code
changes. To tackle that, we convert FlattenList to FlattenedSteps and
explicitly use the steps component.
This commit refactors code for DropdownWidget to handle clicks
on edit and delete buttons in a separate click event handler
and not in the handler for selecting one of the items in
dropdown.
This is important to make sure that selected value stored for
dropdown widget is not updated on clicking the icon.
This commit updates code to require unique names for only
non-archived folders in a realm, which means a folder can
use a name which is being used by an archived folder.
This commit adds live-update code to reset the dropdown when user
is changing the folder for a channel or setting the folder for a
new channel and the selected folder is archived.
This commit updates code to pass aria-label for icon buttons
in dropdown widget options so that they can be used in
dropdown_list.hbs template instead of directly defining them
in the template file.
We currently show buttons in saved snippets dropdown only
so defining the labels in template file worked correctly
but it is good to pass them as variables so that it is
simpler to add buttons for other dropdowns when required.
The order of token values returned by the database query isn't
guaranteed, so 'assertEqual' fails in a flaky way.
This commit uses 'assertCountEqual' to fix that.
The `update_desktop_notification_banner` line removed had been added in #34865,
to handle the case of opening the default user settings panel after previously opening
the personal; notifications settings panel, and is no longer required.
Previously, only one bot can be created using the
generate-integration-docs-screenshot script for each integration. This
was because the bot's email was constructed using the integration's
name.
Thus, the bot-name commandline option would not work if a bot already
exists for the integration.
Now, we create the email by cleaning the bot-name value, if passed.
The format step was converting our ordered list items to have
incremental numbering instead of using `1.` for every list item. This
was not because of any remark-lint rule, but because of
`remark-stringify` which auto increments any lists it processes. We
followed the recommended fix from
ae2f941d88/packages/remark-lint-ordered-list-marker-value/readme.md (L185)
We also don't need remark-lint-ordered-list-marker-value package, since
that is already part of the markdown style guide with the value we
desire. Setting it to false was a mistake in the first place.
