Commit Graph

53261 Commits

Author SHA1 Message Date
Aman Agrawal
3c05bd94a4 inbox: Don't search if there is no change in text. 2023-09-15 12:34:59 -07:00
Aman Agrawal
a0e3f66dc1 inbox: Center focused element if off screen when using keyboard. 2023-09-15 12:34:59 -07:00
Aman Agrawal
7bce78694e inbox: Move scrolling container to html. 2023-09-15 12:34:59 -07:00
Aman Agrawal
c8f363fd45 inbox: Add additional element around rows to apply border-radius. 2023-09-15 12:34:59 -07:00
Aman Agrawal
55eb0e4e07 inbox: Use blue box to indicate focus. 2023-09-15 12:34:59 -07:00
Aman Agrawal
f16273c488 hotkey: Change inbox hotkey from shift + t to shift + i.
Also, add that as a tippy tooltip in left sidebar.
2023-09-15 12:34:59 -07:00
Daniil Fadeev
d96110590b playground_links: Migrate popover to Tippy.
Fixes part of #23632.
2023-09-15 12:25:26 -07:00
Daniil Fadeev
79e050b81b playground_links: Fix disappearing reference when popover is active. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
79c6ff91d7 playground_links: Add popover keyboard handling. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
76891ec9ee playground_links: Add is_open function. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
d27448dcec popovers: Rename playground links popover hiding function. 2023-09-15 12:25:24 -07:00
Daniil Fadeev
1782fb6866 popovers: Rename toggle_playground_link_popover function. 2023-09-15 12:25:12 -07:00
Daniil Fadeev
4d41d8bd02 popovers: Extract playground_links_popover into separate module. 2023-09-15 12:25:11 -07:00
Daniil Fadeev
3773f17933 popovers: Remove unused clear_for_testing function. 2023-09-15 12:24:34 -07:00
Daniil Fadeev
f421ea5e0b user_card_popover: Fix comments that describe a block of functions. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
d2bc1f1bcf user_card_popover: Rename focus_user_info_popover_itemfunction. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
e66eeb4444 user_card_popover: Rename item getter functions.
Renamed functions:
`get_user_info_popover_items` -> `get_user_card_popover_items`
`get_user_info_popover_for_message_items` ->
`get_user_card_popover_for_message_items`
`get_user_info_popover_manage_menu_items` ->
`get_user_card_popover_manage_menu_items`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
27eb545af2 user_card_popover: Rename hiding functions.
Renamed functions:
`hide_message_info_popover` -> `hide_message_user_card_popover`
`hide_all_user_info_popovers` -> `hide_all_user_card_popovers`
`hide_user_info_popover` -> `hide_user_card_popover`
`hide_user_info_popover_manage_menu` ->
`hide_user_card_popover_manage_menu`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
626127451b user_card_popover: Rename toggling and rendering functions.
Renamed functions:
`toggle_user_info_popover` -> `toggle_user_card_popover`
`toggle_user_info_popover_for_message` ->
`toggle_user_card_popover_for_message`
`toggle_user_info_popover_manage_menu` ->
`toggle_user_card_popover_manage_menu`
`render_user_info_popover` -> `render_user_card_popover`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
c579e5fffa user_card_popover: Rename popover elements.
Renamed elements:
`$current_user_info_popover_elem` -> `$current_user_card_popover_elem`
`$current_message_info_popover_elem` ->
`$current_message_user_card_popover_elem`
`$current_user_info_popover_manage_menu` ->
`$current_user_card_popover_manage_menu`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
7b1abd108b user_card_popover: Rename keyboard handling functions.
Renamed functions:
`user_info_popover_handle_keyboard` ->
`user_card_popover_handle_keyboard`
`user_info_popover_manage_menu_handle_keyboard` ->
`user_card_popover_manage_menu_handle_keyboard`
`user_info_popover_for_message_handle_keyboard` ->
`user_card_popover_for_message_handle_keyboard`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
4531386e99 user_card_popover: Rename "*_popped" functions.
Renamed functions:
`user_info_popped` -> `is_user_card_open`
`message_info_popped` -> `is_message_user_card_open`
`user_info_manage_menu_popped` -> `is_user_card_manage_menu_open`
2023-09-15 12:24:00 -07:00
Daniil Fadeev
e0a5d8dc49 user_card_popover: Rename user_info_popover_manage_menu class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
8949ed41b7 user_card_popover_content: Fix template description. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
228a4eb8a2 user_card_popover: Rename user_info_popover class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
b9e1537ee6 user_card_popover: Rename user_info_status_text class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
d5f731f0bd user_card_popover: Rename user-info-popover class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
ff892925ce user_card_popover: Rename info_popover_actions class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
7c3f79df0d user_card_popover: Rename user_info_popover_manage_menu_btn class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
a8bce8e178 user_card_popover: Rename user_info_popover_action_buttons class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
7ce1ee784c user_card_popover: Rename for_user_info_popover template variable. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
d89cd1e241 user_card_popover: Rename Handlebars templates.
List of renamed templates:
`user_info_popover_content` -> `user_card_popover_content`
`user_info_popover_manage_menu` -> `user_card_popover_manage_menu`
`user_info_popover_title` -> `user_card_popover_title`
2023-09-15 12:24:00 -07:00
David Rosa
d862cae3e4 help: Update "Remove users from a stream".
Updates page to follow current help center documentation patterns,
adding Desktop/web instructions to unsubscribe via stream settings.
2023-09-15 10:24:21 -07:00
Anders Kaseorg
9a53baea93 requirements: Upgrade Python requirements.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-09-15 10:12:26 -07:00
Alex Vandiver
2ec288a983 ci: Temporarily upgrade postgresql-client-common before upgrading.
This works around a failure in the current postgresql-client-common
and postgresql-client-15 packages; it exists primarily to improve
the signal on our CI builds, as the failure is a real failure caused
by the package upgrade process.
2023-09-15 07:50:17 -07:00
Prakhar Pratyush
db8229ae32 test_events: Separate tests for send and update message events.
This is a prep commit to separate the single test
'test_stream_send_message_events' into two separate tests named
'test_stream_send_message_events' & test_stream_update_message_events'
to verify the events related to send and update message, respectively.

As a part of introducing two new user settings
* 'automatically_follow_topics_policy'
* 'automatically_unmute_topics_policy'
in the next commit, we will extend 'test_stream_send_message_events'.

This logical separation helps in avoiding a single, super-long test.
2023-09-14 17:16:36 -07:00
Prakhar Pratyush
cf804200c7 tests: Remove the usage of stray desktop_icon_count_display values.
This commit removes the stray values, i.e., [1, 2, 3], used
in the tests for desktop_icon_count_display.

We use 'UserProfile.DESKTOP_ICON_COUNT_DISPLAY_CHOICES' instead.
2023-09-14 17:16:36 -07:00
Prakhar Pratyush
35c3724f22 tests: Fix the incomplete exclusion of the notification settings.
'test_change_user_settings' in 'UserDisplayActionTest' excludes
the notification settings and tests only the display settings.

The code block excluding the notification settings doesn't exclude
'modern_notification_settings'. It only excludes the
'notification_settings_legacy'.

This commit replaces 'notification_settings_legacy' with
'notification_setting_types', which consists of all the
notification settings.
2023-09-14 17:16:36 -07:00
Alex Vandiver
4f4627b79b send_email: Use a consistent order when sending custom emails to users. 2023-09-14 17:16:36 -07:00
N-Shar-ma
54b399ce96 compose: Disable unneeded control buttons in preview mode while editing.
This is a follow up to #26728, which disables buttons in preview mode
for any message being edited.

Care is taken to pass the correct preview state (compose vs the message
row being edited) to the popover menu so the buttons in it too can be
disabled as needed.
2023-09-14 17:15:40 -07:00
Karl Stolley
64d5547f26 help: Match vdots icons to those in use on Zulip. 2023-09-14 17:13:58 -07:00
Karl Stolley
89ce2c112c vdots: Place new more-vertical icon in compose box. 2023-09-14 17:13:58 -07:00
Karl Stolley
b86b7ab067 vdots: Place new more-vertical icon on user card. 2023-09-14 17:13:58 -07:00
Karl Stolley
679f95214c vdots: Place new more-vertical icon in sidebars. 2023-09-14 17:13:58 -07:00
Aman Agrawal
9098648d95 inbox_ui: Take into account unmuted topics when filtering topics. 2023-09-14 13:57:27 -07:00
Aman Agrawal
fa4f9c7eff unread: Remove the TODO statement with an explanation. 2023-09-14 13:57:27 -07:00
Karl Stolley
5737c558cb message_edit: Display GIF button when Giphy is enabled.
CZO discussion:
https://chat.zulip.org/#narrow/stream/9-issues/topic/no.20GIF.20button.20when.20editing/near/1639551
2023-09-14 13:41:02 -07:00
Daniil Fadeev
72fa8b568c timerender: Change relative_time_string_from_date signature. 2023-09-14 11:56:53 -07:00
Daniil Fadeev
84c1a7dc2e recent_view_util: Convert module to Typescript. 2023-09-14 11:56:53 -07:00
Daniil Fadeev
c33328abef recent_view: Remove unreachable code path.
The Message type can only be "private" or "stream," so there's no need
 to handle exceptions in this case.
2023-09-14 11:56:53 -07:00