Otherwise, this fails on `match.group(1)` as there is no match group.
The server would ideally respond with a 521 or 556 code[^1] on initial
connection, but aiosmtpd does not provide that option.
[^1]: https://www.rfc-editor.org/rfc/rfc7504
This fixes an accidental change introduced in #32578.
Forwarding a message and choosing DM should result in
an empty recipient box instead of showing current
recipients.
This commit fixes the kbd element text being centered in dark theme
but not in light theme. Aligns text for all kbd elements not just
in dark theme.
Fixes:zulip#35059.
We reset the internal state while opening the stream settings
overlay to reflect that "Subscribed" tab will be selected.
We did set show_subscribed value to "True" but did not
set show_not_subscribed value to "False".
Due to this opening the overlay, after closing the overlay
when "Not subscribed" tab was selected, resulted in left
panel being shown empty with "Subscribed" tab selected
even when there were subscribed streams because both
show_subscribed and show_not_subscribed were set to "True".
This commit fixes it by setting show_not_subscribed to
"False" as well when resetting the state.
This renames the function to `contains_no_partial_conversations`. The
function initially was created to determine whether its appropriate to
collapse recipient/sender headings. Since then it has many other use
cases, so it's renamed to clearly describe what it does instead.
When there is only one user group, the tooltip appears on the upper side
of the "group-row" and gets hidden.
This commit sets `overflow: visible` which is default value, causing the
tooltip position to invert when there is only one user group.
The "sub_unsub_status" spinner was inside the div with the "check" class
, causing the tooltip to appear over the spinner, which should only be
visible on the check icon.
This commit moves the "sub_unsub_status" spinner div outside, ensuring
the tooltip is now visible only when hovering over the check icon.
The previous logic only worked correctly when user moved from
inbox view to channel topic list view and vice versa.
The logic failed if user moves out of inbox since then `save` state
is never called and hence when restore is called, the navigation
state gets reset.
Fixed by also saving state when inbox is hidden.
We want to prevent users from adding a duplicate or empty
task to the todo list. For this purpose, we disable the
"Add task" button in both the cases.
Fixes: #20211
This commit fixes the behavior when manually changing
the date input instead of selecting from the picker.
Changes done are-
- Users can enter date in various formats including the
one showed in the input like "June 20, 1999", "MM-DD-YYY",
and basically the formats which can be parsed by "Date".
- Fixed handling of invalid strings where we show
"Invalid date value" error message for some time without
sending the request to server.
Fixes#19936.
This is a prep commit to avoid import cycles when we
would use update_user_custom_profile_fields function
in custom_profile_fields_ui.ts in next commit.
It is important to remove the class when hiding the status
element to make sure that when showing status again by calling
some other function than ui_report.message, for example using
loading.make_indicator, the status text should not be styled
as per the class used previously.
One example can be that "Saving" text in indicator can be shown
in "red" color, used for showing errors, if previously an error
response was showed in that status element.
Currently checkbox type input will pass through to the default condition
that records the input elements value. This is inaccurate for checkbox
type input field where it should check for the `checked` attribute
instead.
This is added so that we can use `get_current_values` to get the values
of checkbox inputs too.
This removes the "service" field from the `test_bot` fixture, because it
is a default bot. In the `/bots` API endpoint, only service bots can
have their own service.
This is a prep commit for #34524, this cleans up the test cases related
to service bots so that it would keep things from getting confusing when
adding test for the changes to that PR.
This refactors a CSS variable for checkbox field margin for checkboxes
nested in another field. For example, the "integration events" options
in the "Generate integration URL" modal. Those nested checkboxes are
spaced out closer together.
This is a prep commit for #34524, that PR will add another nested
checkbox in the "Add a new bot" modal.
The `acting_user` parameter is added in preparation to make
`do_update_outgoing_webhook_service` log `RealmAuditLog` when updating
bots service. It doesn't have any use as of right now.
This updates `do_update_outgoing_webhook_service` to use
`BotServicesOutgoing` as the schema for the updated service data we send
back to client because it's the schema `bot_data.update` expects.
The function is also refactored to allow updating specific fields of the
Service row instead of requiring all value for the Service fields to be
passed.
This is a prep commit for #34524, it adds another field to the Service
field.
Prevent displaying the topic resolved banner when the channel
picker (compose_select_recipient_dropdown_widget) is opened in
the case of forwarding messages. This is done to prevent the
overlap of the channel picker and the banner, as it hides some
part of the banner text.
Fixes: #33449
Earlier, buddy list tooltip would get stuck if tooltip was displayed
when redraw for presence update got triggered. This happened due to
tooltip target element was changed but reference element for
mutation wasn't updated.
We are adding video support to the function in upcoming commits and we
need to rename the function for that to be more generic.
We've also added a proper return type in the name of DropboxMediaInfo
TypedDict for the `dropbox_media` function.
We currently don't use either of those operators in email
topic links, which breaks the links on topic moves.
Quoting Tim for choosing `near` vs `with`:
"I guess for each case we should decide if we want /near/ links
to /with/ links. We likely want /with/ in some cases, to make
sure we land in the right conversation but not forcing the scroll
position to be on that particular message, which /near/ does."
"I feel like email notifications might want /near/ if the trigger
is a mention or something else that is specific to the message,
rather than the conversation, but probably /with/ otherwise."
We abstract away "near" vs "with" from the function names and
allow callers to specify whether they want a conversation_link,
ie, use the "with" operator. The default choice is "near".
This commit removes the keep_focus_on_search option from the
DropdownWidgetOptions type, and updates logic to always set
keep_focus_on_search when the search box is visible in the
dropdown.
Fixes: #34828.
