paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
58,103 Commits 30 Branches 160 Tags
4619a1e028e71a5cb6a327f9c922312ba91a1bcc
Commit Graph

58103 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mateusz Mandera
d544a41125 integrations: Rename stream->channel in integrations.md doc. 2024-05-06 09:07:57 -07:00
Mateusz Mandera
87007df8eb webhooks: Rename remaining stream references to channel. 
Note: This doesn't change the occurences in the Zapier integration doc,
since they refer to pieces of the UI in Zapier, which may still be using
the "Stream" terminology.
 2024-05-06 09:07:57 -07:00
Mateusz Mandera
3c4ab345d0 webhooks: Rename append-stream-name.md->append-channel-name.md. 2024-05-06 09:07:57 -07:00
Mateusz Mandera
a119160da3 webhooks: Rename recommended_stream_name->recommended_channel_name. 2024-05-06 09:07:57 -07:00
Mateusz Mandera
1267e10094 webhhoks: Rename stream->channel in bitbucket doc. 2024-05-06 09:07:57 -07:00
Mateusz Mandera
5c9f3cd08c webhooks: Rename create-stream.md to create-channel.md. 2024-05-06 09:07:57 -07:00
Alex Vandiver
3662a6ded9 migrations: Merge 0517 as a no-op. 
Migration 0517 migration was already run as 0497 on `main`, but was
accidentally omitted on 8.x until this point.

Merge the 0517 migration into the migration history.  It is included
as a no-op in `main` because it has already run as 0497.
 2024-05-06 09:03:02 -07:00
Aman Agrawal
4efcc33dc2 echo: Remove checks on current message list. 
Originally, we only wanted to do local echo in the current
view. However, now that we're looking at navigating the user to the
conversation that they send a new message to, it's going to be quite
common that we immediately visit a destination different from the
current view, where local echo in that different view would be
valuable.

The most interesting block was added in
af188205cb / #8989. But in
6637f2dbb7, the key logic for checking
`msg_list.data.fetch_status.has_found_newest` was duplicated in the
`add_new_messages` code path, which critically also updates
`update_expected_max_message_id` and thus may close a race with
fetching message history for a view we're being navigated to, where
the locally echoed message might fail to appear at all.

This change does come with a slight regression: If we are looking at a
search view where the filter is one that we cannot apply locally, a
newly sent message will now be locally echoed (returning the compose
box for drafting another) even though it cannot be displayed in the
current view, which means that the message will not appear in either
the compose box or the current view for the brief period before we get
a reply from the server in this scenario. This is a minor detail,
likely not worth troubling ourselves over.

Given our intent to experiment with navigating the user out of the
search view in this scenario, this is likely not important.

Co-authored-by: Tim Abbott <tabbott@zulip.com>
 2024-05-05 00:23:58 -07:00
Alya Abbott
a27fae16df contributor docs: Improve article on submitting a pull request. 
- Give more guidance on how to think about PRs.
- Structure article as series of steps.
- Link to other pages to avoid duplicating content.
 2024-05-04 23:57:12 -07:00
Alya Abbott
7c90544d14 contributor docs: Reorganize content on pull request docs. 2024-05-04 23:57:12 -07:00
Aman Agrawal
24a167229d message_scroll: Fix check for when to fetch new messages for the view. 
The `at_rendered_bottom` check was incorrect since it includes
bottom whitespace in the calculation to check if we are at the rendered
bottom. This is can cause us to not fetch new messages if user stops
scrolling when bottom whitespace is partially visible leading to
a bad UX.
 2024-05-04 19:07:56 -07:00
Mateusz Mandera
2b927e355a webhooks: Rename stream->channel in some remaining random places. 2024-05-04 19:01:51 -07:00
Mateusz Mandera
2099afe79b webhooks: Rename stream->channel in function name in clubhouse code. 2024-05-04 19:01:51 -07:00
Mateusz Mandera
d7b2655ad2 webhooks: Rename stream_name to channel_name arg. 2024-05-04 19:01:51 -07:00
Mateusz Mandera
fef299510f webhooks: Rename assert_stream_message to assert_channel_message. 2024-05-04 19:01:51 -07:00
Mateusz Mandera
4e968869a2 webhooks: Rename api_stream_message to api_channel_message in tests. 2024-05-04 19:01:51 -07:00
Mateusz Mandera
dc31347ac4 webhooks: Rename STREAM_NAME to CHANNEL_NAME in tests. 2024-05-04 19:01:51 -07:00
Anders Kaseorg
d507706371 zulip_test: Convert module to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-04 18:55:17 -07:00
Anders Kaseorg
fd8b2c557f global: Rename with normal TypeScript module extension. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-04 18:55:17 -07:00
Anders Kaseorg
74237dfd4c global: Convert TypeScript declarations to module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-04 18:55:17 -07:00
Anders Kaseorg
3c06c899c5 katex_server: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-04 18:53:34 -07:00
Tim Abbott
7d3877f69a support: Rate limit demo form requests. 2024-05-04 07:36:16 -07:00
Anders Kaseorg
d4841bbeff settings_components: Fix HTMLSelectOneElement selector. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:58:25 -07:00
Anders Kaseorg
40440248e6 support: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
2be5cb0223 settings_user_topics: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
939b88b9a7 settings_realm_domains: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
4032f9c0cb people: Fix bogus filter_people_by_search_terms type. 
It actually returned Map<number, true>.  Set<number> is more
efficient.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
fb7bad235d message_store: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
4340f400b8 message_store: Fix bogus update_status_emoji_info type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
7a10d8329b message_store: Fix get_cached_message type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
fe6744ae54 input_pill: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
90978c3233 settings_components: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
afeefuddin
1a42798b1d type: Add type HTMLSelectOneElement. 
Combining HTMLSelectElement & {type: "select-one"} into one type to
improve code readability.

Fixes #29909
 2024-05-03 15:32:46 -07:00
Lauryn Menard
5acd059c38 help-relative-links: Update relative help links for channel rename. 2024-05-03 13:05:57 -07:00
Lauryn Menard
14ede84921 help: Update include markdown files for stream to channel rename. 2024-05-03 13:05:57 -07:00
Lauryn Menard
cdc9e83404 help: Rename channel in public access option page. 2024-05-03 13:05:57 -07:00
Lauryn Menard
d10ad01997 help: Rename and redirect archive-a-stream for channel. 2024-05-03 13:05:57 -07:00
Lauryn Menard
c1175f2e55 help: Rename and redirect change-the-privacy-of-a-stream for channel. 2024-05-03 13:05:57 -07:00
Lauryn Menard
500f476de9 help: Rename and redirect change-the-stream-description for channel. 
This also contains in-file edits for help/message-retention-policy.md,
help/create-a-channel.md, and help/configure-automated-notices.md.
 2024-05-03 13:05:54 -07:00
Lauryn Menard
c10c570b89 help: Rename and redirect rename-a-stream for channel. 2024-05-03 13:02:20 -07:00
Lauryn Menard
b714bd9eec help: Rename and redirect set-default-streams-for-new-users for channel. 2024-05-03 13:02:20 -07:00
Lauryn Menard
fbc66f45ea help: Rename and redirect configure-who-can-invite-to-streams re:channel. 2024-05-03 13:02:20 -07:00
Lauryn Menard
c65c2b4a33 help: Rename and redirect configure-who-can-create-streams re:channel. 2024-05-03 13:02:20 -07:00
Lauryn Menard
c931966e1b help: Rename and redirect stream-sending-policy for channel. 2024-05-03 13:02:20 -07:00
Lauryn Menard
5342d4ecfb help: Rename and redirect stream-permissions for channel. 2024-05-03 13:02:19 -07:00
Lauryn Menard
95b03ce6e1 help: Rename and redirect manage-user-stream-subscriptions for channel. 2024-05-03 12:55:39 -07:00
Lauryn Menard
859340c914 help: Rename and redirect mute-a-stream for channel. 2024-05-03 12:55:39 -07:00
Lauryn Menard
4908f1c5dc help: Rename and redirect stream-notifications for channel. 2024-05-03 12:55:39 -07:00
Lauryn Menard
d97571e1df help: Rename and redirect manage-inactive-streams for channel. 2024-05-03 12:55:39 -07:00
Lauryn Menard
93dd1e9b25 help: Rename and redirect move-content-to-another-stream for channel. 2024-05-03 12:55:39 -07:00