Commit Graph

36711 Commits

Author SHA1 Message Date
Anders Kaseorg
4d04fa3118 compose: Rewrite Zoom video call integration to use OAuth.
This reimplements our Zoom video call integration to use an OAuth
application.  In addition to providing a cleaner setup experience,
especially on zulipchat.com where the server administrators can have
done the app registration already, it also fixes the limitation of the
previous integration that it could only have one call active at a time
when set up with typical Zoom API keys.

Fixes #11672.

Co-authored-by: Marco Burstein <marco@marco.how>
Co-authored-by: Tim Abbott <tabbott@zulipchat.com>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2020-06-03 16:39:12 -07:00
Anders Kaseorg
7a53da7526 capitalization: Fix OAuth capitalization.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-06-03 16:39:12 -07:00
Anders Kaseorg
fa9bddcfb2 emoji: Add workaround for collectstatic step of build-release-tarball.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-06-03 16:39:12 -07:00
Tim Abbott
8d9d36cbc7 api docs: Fix whitespace in changelog articles. 2020-06-03 14:30:32 -07:00
Tim Abbott
999554734c docs: Clarify that linkifiers are Python 3 regular expressions.
Also tone down the "contact support" text; we've fixed most of the
issues that led to folks needing to do that.
2020-06-03 14:05:39 -07:00
Rohitt Vashishtha
4b47d219db settings: Use correct label for signup notifications stream.
When migrating to dropdown list widget, we incorrectly used the same label
for both realm_notifications_stream and realm_signup_notifications_stream.

This was introduced in b580baf682.
2020-06-03 12:19:08 -07:00
SiddharthVarshney
ecd383b53c css: Use SCSS nesting for nav. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
ff75ea838f css: Reorder nav .content and nav ul. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
3435396479 css: Reorder nav .hamburger. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
dcbc4f8630 css: Reorder nav.white. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
f57a512ab3 css: Use SCSS nesting for nav li. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
2130c3018e css: Use SCSS nesting for nav li. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
d4d326c827 css: Use SCSS nesting for nav ul li. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
de4396661b css: Use SCSS nesting for nav ul li.active. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
dcc658264c css: Reorder css related to nav ul. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
948b54e519 css: Use SCSS nesting for nav .logo. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
d21d13698e css: Reorder css for nav .logo span. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
756722616e css: Use SCSS nesting for nav .content. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
5009bedba4 css: Remove redundant css for nav .logo span. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
e5c1be0584 css: Use SCSS nesting for nav.white. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
3a81099972 css: Use SCSS nesting for nav.white ul. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
f4f99e7ca6 css: Use SCSS nesting for nav.white li. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
96db3fa650 css: Use SCSS nesting for nav.white .brand.logo. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
70a025d08d css: Reorder nav.white .hamburder. 2020-06-02 17:26:45 -07:00
SiddharthVarshney
bfad22d128 css: Remove duplicate style. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
1ac597c77e css: Use SCSS nesting for .silver. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
a10a78736d css: Reorder styles related to .silver. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
b29b7b8da1 css: Use SCSS nesting for .float. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
8317bde30f css: Reorder css related to h1 and h2. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
ea704c8c91 css: Use SCSS nesting for a. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
e520e82b04 css: Use scss nesting for a.arrow. 2020-06-02 17:26:45 -07:00
Siddharth Varshney
cc71533b21 css: Reorder css for a tag. 2020-06-02 17:26:45 -07:00
orientor
1227b65066 openapi: Forbid opaque objects from OpenAPI documentation.
Objects whose properties are not described were validated by the
current validator. Edit it so that objects with no `properties`
or `additionalProperties` attribute i.e. opaque objects get
invalidated.

Also make changes in zulip.yaml to fix any opaque objects (tweaked by
tabbott to edit the documentation for better clarity).
2020-06-02 16:45:06 -07:00
orientor
8224400166 openapi_responses: Improve response validation tests.
Currently, `validate_against_openapi_schema` checks only the top
level of the response dictionary. Improve it so that it can
validate objects and arrays at all levels. Also edit zulip.yaml
accordingly. And for new response keys which were not defined
before add VERY basic documentation.
2020-06-02 16:34:54 -07:00
sahil839
0b432e26b6 test_subs: Add tests for unsubscribing multiple users from stream.
This commit adds tests for unsusbcribing multiple users from a
stream and fixes the missing coverage issue introduced in 2187c84.
2020-06-02 16:27:22 -07:00
sahil839
c4d3c03ad4 compose: Fix subscribing the user from mention warning.
This commit fixes the bug for subscribing the user from mention
warning which was introduced in e52b544.

This is fixed by changing email to be passed as list to
'invite_user_to_stream'.
2020-06-02 16:25:56 -07:00
Sahil Batra
77d4be56a4 users: Modify do_create_user and create_user to accept role.
We change do_create_user and create_user to accept
role as a parameter instead of 'is_realm_admin' and 'is_guest'.
These changes are done to minimize data conversions between
role and boolean fields.
2020-06-02 16:11:36 -07:00
Ryan Rehman
cfc87e3925 message list: Move the FetchStatus object to MessageListData class.
The reason for this change is that, this is where `Filter` and
actual tracking of what messages are contiguous lives. This
will be beneficial when we will to move to a model where we
cache `MessageListData` objects for a large number of views.
2020-06-02 15:45:39 -07:00
sahil839
e52b544213 stream settings: Add pills in add subscribers input.
This commit changes the stream settings UI for adding subscribers to
use our standard user pills in the input box, rather than just
plain-text email addresses.  This is important progress towards
removing display email addresses from the Zulip UI.

It also allows subscribing multiple users at the same time, which is a
nice improvement.
2020-06-02 15:32:26 -07:00
Hemanth V. Alluri
18f8859baa refactor: Remove unnecessary request_data param in outgoing_webhook.
request_retry and notify_bot_owner don't use request_data so might
as well not send it to them at all.

Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-06-02 15:19:27 -07:00
Hemanth V. Alluri
9c172036bb refactor: Make OutgoingWebhookServiceInterface more interface like.
Using the Python Standard Library's abc library and NotImplementedError
we can better define interfaces (this is mainly to improve readability
and consistency).

Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-06-02 15:19:27 -07:00
Mateusz Mandera
3e7fc17788 auth: Delegate RemoteUser SSO to browser when using the desktop app. 2020-06-02 13:00:17 -07:00
Sahil Silare
c4d0bd6445 settings: Fix last_active sorting in user settings.
We were incorrectly accessing .id, not .user_id, on the people objects.

Fixes #15165.
2020-06-02 12:07:09 -07:00
Tim Abbott
f93c19ec62 openapi: Fix various errors in OpenAPI declarations.
Based on original work by Aditya Verma to tag places where our API
documentation was inaccurate / incomplete.
2020-06-02 11:54:19 -07:00
Sharif Naas
7e681c934c docs: Fix anchor link written in reference link syntax.
This has been broken since it was added in a rewrite in July 2019 in
c931e76cf2. An incomplete fix was
made a few days later in 871fd57f5e.
2020-06-01 18:31:05 -07:00
Sharif Naas
bb0b82f397 docs: Fix "report an issue" link in README.md.
This link has been broken since it was added in November 2017, when
CONTRIBUTING.md was split out of README.md in
ee2ea3750c.
2020-06-01 18:31:05 -07:00
Sharif Naas
267c427677 docs: Fix broken and missing link references in Git guide.
These references broke in November 2017, when git-guide.md was split
into multiple files in fa3602b61f.
2020-06-01 18:31:05 -07:00
Puneeth Chaganti
d2dadde381 tools: Use the correct path for bot avatar to generate screenshots. 2020-06-01 18:08:23 -07:00
Puneeth Chaganti
788203778d tools: Use the correct logo path to generate bot avatar.
Integrations can be configured with specific logo paths, which weren't
correctly being used for generating the bot avatars.
2020-06-01 18:08:23 -07:00
Puneeth Chaganti
dfd4b4d051 integrations: Store logo_path as an attribute along with logo_url.
Integrations can be supplied a logo parameter which is used to contruct
their `logo_url`. It would be useful to store this parameter, instead of
computing the path from the URL.
2020-06-01 18:08:23 -07:00