This is the final naming that we want, compared to the naming we merged
in #32399.
Includes renaming the API endpoints, but that should be fine as the
original PR was just merged and this isn't deployed anywhere.
In user group popover, if a group has more than 30 members, just show
the first 30 members and add links to member management pages.
If a group is a system group, link to organization user
page. Otherwise, link to group member page.
Fixes#31550.
The context property was previously being used in the macro
`git-webhook-url-with-branches` which has been removed as it is not in
use any longer.
The context property was now being used only in 2 integration docs, both
of which used it only in a single location, and directly used their own
names as the channel name. Making the context property unnecessary.
The `append-channel-name` and `append-topic` macros' instructions are
unnecessary as the topic and channel names are now part of the generated
URL.
The `git-webhook-url-branches` macro becomes equivalent to
`git-append-branches` with the auto-generation of the URL.
Removed `bot_creation_policy` property, as the permission to create
bot users in the organization is now controlled by two new realm settings,
`can_create_bots_group` and `can_create_write_only_bots_group`
Added `can_create_bots_group` setting which controls who can
create any type of bots in the organization.
Added `can_create_write_only_bots_group` setting which controls
who can create incoming webhooks in the organization in additon
to those who are in `can_create_bots_group`.
This commit tries to address the problem of not getting the
latex markdown on selecting and quoting a message which
contains normal text as well katex html elements.
It works by grabbing the parent of all the katex elements,
display (mathblocks) as well as inline expressions
and iterating over each immediate child to convert the
elements into markdown based on certain conditions.
Support has also been added to convert inline expressions to an
approximate markdown representation.
To facilitate selection of inline math expressions along with
text nodes, which are intermediate pieces of text sandwiched
between two katex spans, we transform the paste_html to
have spans instead of text nodes, so that they can be
processed by turndown js, since its filter function only
iterates through Elements and not TEXT_NODE.
The new tests have been added in katex_test_cases.json to
prevent cluttering the node tests in copy_and_paste.test.cjs.
These tests are looped over in the node tests.
Fixes#31608.
This commit uses the same fix as the commit 6776e80, to include
`bootstrap.portico.css` and prevent webpack from misordering it from the
rest of the portico CSS chunk.
This commit adds the align-items property to the modal__spinner class.
This property sets the spinner in the modal to the center without
changing the spinner's position.
This commit redesigns the link styles based on the Figma designs by
Vlad Korobov, and implements them in the navbar banners. This also
removes the `--color-text-link` which was being used in the custom
profile field links in the user card popovers while the variable did
not exist previously.
This commit fixes the bug where the focus ring was not visible while
tabbing through the buttons due to values being overridden. This also
fixes the outline offset for the banner close button to make it visible.
This commit Increases the left margin of the action buttons group to
add more space between the banner label and the action buttons improve
the visual consistency with the gap between the action buttons and the
banner close button.
This commit removes the unused code for the navbar banners from the
codebase after these banners have been updated to use the new banner
styles.
Fixes#31280.
This commit attempts to improve the desktop notifications banner logic
by keeping a track of the notifications granted state, and only closing
the notifications banner if the user explicitly denies or grants the
permission access, or if it is denied by the browser due to repetitive
prompts for notifications permission.
As part of the banner redesign project, this commit applies the new
banner styles to the desktop notifications navbar banner.
This commit also acts as a base for the following banner redesign
commits by defining the `banners.ts` module, which now acts as the
centralized module to handle the banner rendering and sets up the
common event listeners.
Renames "Add a new saved snippet" to "Create a new saved snippet" and
"Add saved snippet" tooltip to "Insert saved snippet".
Moves "Create a new saved snippet" button to the bottom sticky area of the
dropdown.
Adds `sticky_bottom_option` element to the `dropdown_widget` to
support moving of "Add a new saved snippet" button to the bottom
sticky area of the dropdown for better accessibility and UX.
This is follow-up of #31359 that moves "Saved snippets" button from
"send_later" popover to message formatting buttons and adds support
to use saved snippets in message-edit UI.
Fixes#31830.
This serves as a way to escape the subjectively annoying
requirement of having to press Tab/Enter twice to complete
a stream typeahead, in cases where you only want
to mention a stream.
Consider you write `#des` and then press `Tab`
This will put `#**design>` in the textarea and
add trigger the topic typeahead menu.
Now if you continue writing text right after the ">"
like `#**design>my sample text` and press ESC key, it
will be converted to `#**design** my sample text`.
This provides convenience of not having to press Tab
twice in order to mention stream and write some text
or just a stream mention using the Tab + Esc combination.
Enable a consecutive topic typeahead after a user selects a stream via the
typeahead menu. Previously, users had to manually enter ">" after selecting
a stream.
Before, encountering ">" returned "topic_jump," which prevented the
topic list from triggering since "topic_jump" indicated the topic was
selected. The implementation is changed to slice the token and process it
in get_candidates to trigger the appropriate typeahead.
Adjustments include changes to regexes for accurate triggering of stream or
topic typeaheads based on the presence of ">" in the current token.
Removes hint for stream mentioning use of ">"
for topic suggestions, although that feature is
still functional.
The hideAfterSelect() function in composebox_typeahead.ts was modified.
This prevents closing the typeahead when a stream is completed.
The TopicSuggestion type is updated to show stream typeahead suggestion
as the first option in the topic list with a privacy icon and no description
in case when no character follows the '>' i.e. when the token ends with '>'.
The edge where stream and topic have the same name is also handled with
the help of a flag.
Add stream as the prefix to topic suggestions in the typeahead.
To make this happen, changes are made in the related handlebars
template.
Update topic list stream option label.
This changes the option label for stream in the topic
list from (mention channel) to (link to channel) as per
https://zulip.com/help/link-to-a-message-or-conversation.
Tests are updated, and a new test is added to validate the behavior.
Test coverage is added for the new `render_stream_topic` method.
Fixes: #32184.
This commit adds support to render long descriptions
on hovering over the narrow description.
Hides the title and associated privacy icon below
a particular screen to create more room to show
the extended description.
Sets a fixed width in case of bigger screens
for word-wrap to work.
Fixes#14729.
If the user is navigating via keyboard and the top / bottom of
the message is not visible, we scroll instead of selecting the
next message to allow user to completely see that message.
Made maybe_negated a required parameter in
check_not_both_channel_and_dm_narrow so that it doesn't raise error
when -is:dm is called with channels:public or
when -channels:public is called with is:dm
Fixes#33033
