Earlier, permission in edit panel of channel settings was not the
same as that of org permission, specifically for public channel
option.
This commit fixes that by updating the privacy option state.
Fixes:zulip#34526.
Currently when a deactivated user tries to access the change email link
(generated when their account still active), a JSON error message will
be shown.
This adds a new portico error page for user deactivated errors. Now,
`confirm_email_change` renders a portico error page when the user trying
to change their email is deactivated.
Fixes#20227.
Work towards #34244
This is the only call to `peer_data.is_subscriber_subset`, so after
this commit all calls to that function work with our new model for
partial subscriber data.
Omit<…, "undefined"> removes the "undefined" key from an object. The
intention was clearly Exclude<…, undefined> which removes undefined
from a union, or NonNullable<…> which removes both undefined and null.
However, it’s simpler here to provide the expected type directly.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Changes done here are -
- Previously the pill input, "Add" button and tooltip shown
when user did not have permission were not live updated when
updating can_add_subscribers_group and can_subscribe_group
stream level settings or can_add_subscribers_group realm
level setting. This commit fixes that.
- Also, when the UI was live updated to give user permission
to subscribe others, "Add" button was enabled even when
input was empty. This is also fixed in this commit.
This commit refactors code to live update UI for a couple of
group settings by setting the live update functions for those
settings in realm_settings object.
Work towards #34244.
Note that this doesn't show the right counts when the counts appear, because
yet. We can double check functionality after that change is complete.
We have added an ability to partially load subscribers,
and this function name makes it more clear what it returns,
in contrast to an upcoming `get_full_subscriber_set`.
This was added in b387ca4, before we had
`buddy_list.update_empty_list_placeholders`
Now it's not only duplicating that functionality, but will soon
maybe run at the wrong time once the buddy list `populate` starts
making `void` calls to `async` empty list placeholder code.
This commit
- Replace the blank option with an italicized option that's the current
default language, if there is one selected with "default" label.
- Make the "text" option more informative by adding (no highlighting)
to the label.
- Remove the hint for "text".
- Prioritize as left to right, before start typing:
blank/default language, text, quote, spoiler, math, everything else...
fixes: #33682
Removing `.alert` from the dark theme seems acceptable,
as there is nowhere in the codebase we're setting a
`text-shadow` value that would require `none` here.
This helps preserve the original form in production.
The new "Import from" option button allows user to automate the
process, so this is not required in that case.
Updates the example banner in the devtools banner design page
for the changes to the demo organization banner.
This removes all uses of the banner-link class, but we keep the CSS
rules, since they're part of a component we may use elsewhere.
