The "maxlength" attribute for "Full name" input in "Profile"
settings panel was incorrectly set to 60, when we allow
maximum 100 characters. This commit fixes that.
Partially fixes#35129.
Prettier could not be used because of prettier issue number 12209, not
linked here to avoid spam backlinks on the original issue. Prettier does
not have support for mdx v2 and v3.
We are using remarkLintRulesLintRecommended and
remarkPresentLintMarkdownStyleGuide as our starting set of rules.
None of the rules were giving an error on the starting set, but some
rules were giving lots of warnings on the generated mdx. They are
set to false in this file, we can add them back later as and when
required.
We have not inserted this in the main lint tool, we should do that in
the final cutover PR since we don't want the lint here to give any
unexpected warnings when people are linting stuff unrelated to the mdx
files.
This commit has been tested out on the current state of help center to
not produce any errors or warnings. The first run of format will produce
tons of warnings which are the issues being auto-fixed by the linter.
After that, the second run should produce zero errors.
The linting in our new help center does not allow empty urls, so we
need to fix it at source before conversion. We replace these with
destinations on the current page.
This repeats #34801, but also covers the cases where the msgstr was
already trimmed, because the translator did not bother to include the
leading/trailing whitespace in their translations.
In some cases, some of the starlight css was inserting a margin top of
1rem to the svg tag inserted by unplgin-icons. We make the top margin
0 explicitly to make sure that extra margin is not added.
Slug was mentioned for the two entries in question as if they were
normal help pages, but they were external links and should have been
mentioned accordingly.
This repeats #34801, but also covers the cases where the msgstr was
already trimmed, because the translator did not bother to include the
leading/trailing whitespace in their translations.
We show the UI to send email to the user being deactivated when
deactivating user from button in "Manage user" section of user
profile modal, but the email text was not included in the API
request sent to server and thus no email was sent. This commit
fixes it to send the email if it was configured while deactivating
the user from "Manage user" modal.
0229f73fae introduced a bug wherein
while caching the media assets keyed using the message id, previews of
media from composebox which also used same codepath attempted to find
the message id from the asset. This resulted in an assertion error.
This is fixed by making sure that compose previewable assets are
never cached nor attempted to fetch from cache since they don't
have a message id yet.
Co-authored-by: Tim Abbott <tabbott@zulip.com>
APNs tokens are provided by the client in hex, and we store them in
hex. The existing code which attempts to "validate" them by parsing
them as base64 only works because base64 is a superset of hex.
Enforce that APNs tokens are hex, and remove all of the pieces of test
code which were incorrectly passing them in as base64 strings.
This updates the topic name format for Slack threads to include a
snippet of the original message. Currently the format looks like this;
"{date} Slack thread {n}", which provides little to no context about the
thread.
Currently we also use the `thread_ts_str` key to keep track of Slack
threads we're converting, this key format makes it so that it has a
small chance of combining threads with the same timestamp under one
topic. This commit updates it to use a new key format, `thread_key`.
Fixes#27661.
Uses the approach done for email change confirmations in #34980 to avoid
triggering a reactivation via just a GET request. Instead, the GET
should return a page which will trigger the browser to then POST the key
to the endpoint.
This reverts commit 458c660f65.
We realized we need one more pull request before we can turn this on.
I kept the hunks related to finalizing the cutoffs.
