I noticed that when you are in a group dm narrow
and open drafts, the overlay-message-row class
is inside different containers, and the nth last
child check does not apply for that case, which is
why the test failed.
More generally, last-child is just not a good selector for robust
testing.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Links become unclickable if the following is true:
1. Composebox is open
2. You have selected some text
Currently doing this will prevent the default click behavior
which is a big bug and can get quite annoying.
We now switch to a more robust check which only prevents the
click behavior if some drag evidence is present, determined with
`mouse_drag.is_drag`
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
When run from cron, reload-server (and thus reload-clients) picks up
the `HTTP_proxy` environment variable, which redirects HTTP requests
through Smokescreen -- which prevents localhost requests. This
results in clients never getting sent reload events.
Explicitly unset proxies when talking to localhost in reload-clients.
We enforce at registration time that hostnames with deactivated=False
must be unique, though we do not enforce it in the database because we
have historical data for which that is not true.
However, we should perform all hostname lookups with a
`deactivated=False` filter, as that will resolve the majority of
`RemoteZulipServer.MultipleObjectsReturned` errors. Once the
production data is cleaned up, this can be enforced via a partial
unique index.
This avoids a potential unnecessary message.recipient fetch required by
is_stream_message(). is_stream_message() methods precedes the addition
of the denormalized is_channel_message column and is now unnecessary.
In practice, we usually fetch Message objects with `.recipient` already,
so I don't expect any notable performance impact here - but it's still a
useful change to make.
As per the type definition of `NarrowTerm`,
the operand should be a string.
This bug caused exceptions each time a topic was
clicked in the left sidebar.
Previously, tooltip templates were identified using the
group's name in their `id` attributes.
This change uses the group's ID instead, which is more reliable.
Previously, tooltip templates were identified using the
stream's name in their `id` attributes.
This commit changes the tooltip IDs to use the stream's ID instead,
rather than its name, to ensure uniqueness and avoid potential conflicts.
Adds general help description text for the tool that generates
cropped message screenshots for corporate pages.
Notes some of the known issues when updating these screenshots
after there have been UI changes, such as partial dates showing
and truncated channel/topic names in screenshots.
Fixes the screenshots on the for/education page to have the
canonical last name for the example user Elena Garcia.
Updates year in dates for screenshot content to align with when
the screenshots were taken.
Adjusts the width of the viewport for changes in the message
header bar in the web app. Also closes any alert banner at the
top of the app before navigating to the narrow so that doesn't
impact the cropped screenshot area that's computed later.
Finally, sets hover on the new conversation button so that none
of the message action buttons are visible in the message feed
when the screenshot is taken.
This parameter should be marked as required, but allowing an empty
string value. Updates the description of the parameter to be more
explicit of that fact.
Adds a visible example to the PATCH /channel_folders endpoint for
reordering an organization's channel folders. So that the example
works in a normal dev environment, we also add a second channel
folder when populating the dev database.
This is done synchronously, despite taking ~60s. We can move it to a
background thread later if that's an issue, but generally Prometheus
is tolerant to exporters taking a while to come back with results.
An error was raised where we tried to live update the folder name
in folder dropdown even when there was no dropdown visible
to the non-admin user in settings page. This was because
"There are no channel folders configured in this organization."
text was shown even when a folder was recently created in the
realm as we did not live update the visibility of dropdown on
creating or archiving a folder.
This commit fixes the bug by live-updating the visibility
of folder dropdown when creating or archiving a folder.
Previously, the API key was shown using a variable-width font, making
characters harder to distinguish. This change applies a monospace font to
improve readability and visual consistency.
Fixes#35189.
Co-authored-by: rxkshit04 <rakshitatwork@gmail.com>
Co-authored-by: cpu-ram <petr.stepanenko@gmail.com>
