paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 19:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity
20,596 Commits 30 Branches 160 Tags
bb655e694548f03247bb42e197cac744da45235c
Commit Graph

20596 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim Abbott
bb655e6945 css: Fix selecting of the EDITED notices. 
Apparently, the previous approach didn't actually work.
 2017-08-27 22:54:34 -07:00
Tim Abbott
b988a1c661 css: Fix selecting of EDITED notices and weird whitespace. 
This completes the effort to make selecting messages work in a way
consistent with what users might expect to be correct.

Fixes #5328.
 2017-08-27 22:18:30 -07:00
Tim Abbott
b49448de7d message_edit: Eliminat whitespace in recipient row controls. 
This is hacky, but I can't figure out another way to do it that
doesn't cause other problems.

Ideally, we'd add some sort of exclude rule to our HTML template
linter so we can check the rest of the file.
 2017-08-27 22:18:29 -07:00
Tim Abbott
3c8eb3c743 message_edit: Create recipient_bar_controls span. 
This refactor will facilitate making it possible to set CSS properties
on this controls span; in particular, we're hoping to disable user
selection of the whitespace in this region.

The main side effect of this refactor is that we need to add JS code
to also hide the icon-vector-pencil element, since it's now in a new
span.
 2017-08-27 22:18:05 -07:00
Tim Abbott
f0d8e22b69 css: Don't allow selecting whitespace between hover controls. 
This is inspired by #5486 and fixes part of #5328.
 2017-08-27 22:18:03 -07:00
Steve Howell
37bf89292a Fix deleting stream from the sidebar. 
When we were deleting a stream from the sidebar using the
stream/delete event, we were getting tracebacks due to this sequence
of operations:

    * remove id from stream_list.stream_sidebar
    * rebuild stream list
    * remove sub from stream_data

This fixes the bug by calling stream_data.delete_sub() first.

Deletions are tricky if you do things out of order.  We can probably
prevent tracebacks by having a deleted flag, but that can just cause
different problems.

Last commit tweaked by tabbott to fix a small bug in handling the case
where the user was not subscribed to the delete stream.
 2017-08-27 19:11:43 -07:00
Steve Howell
38664e8cad Remove unused call to /json/streams endpoint. 
We no longer need /json/streams in settings_streams.js.
 2017-08-27 19:08:04 -07:00
Steve Howell
660854f5ad admin: Use client-side data to populate list of streams. 
Fixes #3786
 2017-08-27 19:08:04 -07:00
Steve Howell
3846e60a71 Add stream_data.get_streams_for_admin(). 2017-08-27 19:08:04 -07:00
Steve Howell
2c925e3567 stream_settings: Remove all_streams variable. 
We no longer need this global variable after the prior commit.
 2017-08-27 19:08:04 -07:00
Steve Howell
106d58df47 Add stream_data.get_non_default_stream_names(). 
This allows us to get the typeahead values for adding a default
stream using client-side data.
 2017-08-27 19:08:04 -07:00
Steve Howell
b32a9444dd js: Clean up how we track default stream names. 
We continue to have page_params.realm_default_streams, but
now we do lookups on whether a stream is a default stream
by using a Dict indexed by stream_id.

We are also careful to update that during live updates.

This fixes a flaw that we weren't updating the list of realms
correctly for events that remove a default stream.
 2017-08-27 19:08:04 -07:00
Steve Howell
73c30774cb admins: Add private streams to never_subscribed. 
Admins need to know about private streams to delete them, even
if they are not subscribed.  We send the minimal info possible
to the client to allow them to have a UI for that.
 2017-08-27 19:08:04 -07:00
Steve Howell
8ea9b80a8c Clean up test_never_subscribed_streams(). 
This basically extracts a few helper methods and makes the data
setup a bit more explicit.
 2017-08-27 19:08:04 -07:00
Steve Howell
313f73258d Allow admins to delete private streams (backend only). 
This is the backend piece.  Getting the UI right here is a bit
more complicated here, but this allows admins to use the API
to delete streams.
 2017-08-27 19:08:04 -07:00
Tim Abbott
480d642eff travis: Add a networking retry for codecov installation. 2017-08-27 19:07:02 -07:00
Tim Abbott
2d11a67975 soft_deactivation: Change cron job to run daily. 
This seems like a more consistent default model than weekly.
 2017-08-27 18:40:31 -07:00
Tim Abbott
6d5dac96c6 zulip-puppet-apply: Fix flushing of stdout for Python 3. 
Apparently, this UI worked just fine with Python 2, but failed to
actually print usefully with Python 3.
 2017-08-27 18:36:39 -07:00
Aditya Bansal
d9c9bfe7f6 logger: Add new create_logger abstraction to simplify logging. 
This deduplicates a ton of Python logger-creation code to use a single
standard implementation, so we can avoid copy-paste problems.
 2017-08-27 18:31:53 -07:00
Tim Abbott
e092f1afff logging: Fix soft_deactivation log declaration. 
Apparently, the soft deactivation log was incorrectly grabbing the
root logger, and thus screwing up where everything got logged.
 2017-08-27 18:30:52 -07:00
Tim Abbott
1a1df29053 get_recent_deployments: Skip uwsgi socket and friends. 
This fixes an exception when running clean-venv-caches in production.
 2017-08-27 18:18:53 -07:00
Tim Abbott
e38ac00f3c caches: Move cache cleaning helper tools under scripts/lib. 
This helps keep the root of scripts/ uncluttered.
 2017-08-27 17:59:49 -07:00
Harshit Bansal
f90f9c7404 scripts: Add clean-unused-caches script. 
This script can be used for running all the three cache cleaning scripts
in one go.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
e5361b4403 clean_emoji_cache: Expand clean-emoji-cache. 
Expands `clean-emoji-cache` so that it can be used in production
environment as well. Also moves it to `scripts/` from `tools/`.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
facb5dbe85 zulip_tools.py: Extract generate_sha1sum_emoji(). 
Given the path of a zulip installation, it returns a hash corresponding
to the emoji infrastructure of that installation.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
948cf54ee3 clean-npm-cache: Expand clean-npm-cache. 
Expands `clean-npm-cache` so that it can be used in production
environment as well. Also moves it to `scripts/` from `tools/`.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
8e41bbe2b0 node_cache.py: Modify generate_sha1sum_node_modules(). 
Modify `generate_sha1sum_node_modules()` such that it can calculate
the hash for a particular installation.

Tweaked by tabbott to use os.path.realpath in the setup_dir
calculation, to ensure it's consistent.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
8aadbc258d clean-venv-cache: Don't remove the currently active cache in dev. 
In dev always include the currently active cache in order not to break
current installation in case dependencies are updated with bumping the
provision version.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
5e2b54446f clean-venv-cache: Directly import functions from 'hash_reqs.py'. 
Instead of running the 'hash_reqs.py' as a script, directly import
functions from it to calculate the hash. This will speed up the
script.
 2017-08-27 17:51:24 -07:00
Harshit Bansal
ecbc75e00f clean-venv-cache: Migrate to use purge_unused_caches() function. 2017-08-27 17:51:23 -07:00
Harshit Bansal
36420ab636 zulip_tools.py: Add purge_caches() function. 
This function can be used for purging unused cache directories.
 2017-08-27 17:37:08 -07:00
Tim Abbott
5d974b7f57 emoji: Remove :s from emoji popover title attributes. 2017-08-27 17:34:44 -07:00
Harshit Bansal
90d8b0f520 emoji_picker: Fix the two different titles appearing for each emoji. 
Fixes: #6286.
 2017-08-27 17:22:44 -07:00
Harshit Bansal
923fb7be16 emoji: Fix mis-alignment of realm emoji div with other div in emoji picker. 
Tweaked by tabbott to fix the CSS to not break the emoji typeahead.

Fixes: #5229.
 2017-08-27 17:21:08 -07:00
Tim Abbott
36fa6fe548 css: Remove duplicate emoji height CSS. 2017-08-27 17:20:37 -07:00
Tim Abbott
e68de7ac8d user popover: Don't throw an exception for deactivated target users. 
Ideally, we'd fix this at the root cause, via #4322, but this will at
least suppress the exception for now.
 2017-08-27 16:41:28 -07:00
Tim Abbott
3e1bf86ced hotkey: Make enter checks more strict. 
This should hopefully fix an obscure traceback we were seeing.
 2017-08-27 16:35:17 -07:00
Tim Abbott
478f691792 settings: Remove useless map_initialized. 2017-08-27 16:35:17 -07:00
Tim Abbott
70e16da81c decorator: Fix request.user handling of remote servers. 
The refactor in b46af40bd3 didn't
correctly translate the code for managing request.user and
request._email, resulting in requests for the push notification
bouncer being rejected with this exception:

AttributeError: 'AnonymousUser' object has no attribute 'rate_limits'
 2017-08-27 16:35:17 -07:00
Tim Abbott
a1885c6ffb message_edit: Add debug logging for missing messages. 
This is an attempt to more easily debug a traceback we've seen a few
times.  The issue likely has to do with local echo, which would be
confirmed if this reports a local-echo-style message ID.
 2017-08-27 16:11:42 -07:00
Tim Abbott
90012f8109 find_add_class: Don't check frontend tests. 2017-08-27 14:04:46 -07:00
Tim Abbott
ce1a8bf5b2 find_add_class: Include full path names in error messages. 2017-08-27 14:04:46 -07:00
Tim Abbott
b1d98c1d0f lint: Only run find_add_class when JS files change. 2017-08-27 13:51:06 -07:00
Tim Abbott
79ae262463 lint: Only run check-urls after python files change. 2017-08-27 13:51:06 -07:00
Robert Hönig
3f01907d3b travis: Distribute linting over frontend and backend suites. 2017-08-27 13:51:06 -07:00
Robert Hönig
c5da0ada31 linter: Replace --pep8 with new --frontend/--backend options. 
Adds the --frontend and --backend options to replace
--pep8.

Significantly modified by tabbott to use a cleaner framework.
 2017-08-27 13:50:53 -07:00
Robert Hönig
2186d53cf5 linter: Migrate lint from optparse to argparse. 2017-08-27 13:18:55 -07:00
Preston Hansen
5a501784f2 digest emails: Add unit tests for digest email management. 
Fixes #6266.
 2017-08-27 13:10:14 -07:00
Vishnu Ks
8fc8ac0799 management: Override CommandError to mention --entire-server argument. 2017-08-27 12:34:23 -07:00
Vishnu Ks
dc63f838d7 backend-tests: Add tests for get_users with all-users argument enabled. 2017-08-27 12:34:23 -07:00