Spectators don't have a right sidebar, and apparently combining the
right-sidebar hiding logic with that results in a glitchy search bar.
Avoid either setting or reading from the right sidebar persistence
configuration. We don't do anything with the left-sidebar toggle,
since that living in local storage seems reasonable.
Fixes#34007.
When the user is hovered on the send button and uses keyboard
to update the compose box, the tooltip was not updated. This
fixes that edge case by hiding and showing the tooltip again.
Compose send tooltip was not correctly displayed when the compose
box was in an invalid state.
We significanlty improve the logic for displaying the tooltip here
to provide a more robust experience to the user.
This commit updates how we show the text mentioning that archiving
a stream which is used for new user, new channel or update
announcements will result in the announcements not being sent.
Fixes#33379.
Previously, stream archive button was only shown to realm admins.
Now button is shown to all the users who can administer the
channel.
Fixes part of #33379.
Doing a lot of DOM manipulation on message hover leads to
tooltips being not hidden / displayed when they should be.
This commit is an attempt to optimize that code to do minimal updates.
Earlier, we used to show "general chat" as the placeholder.
This commit adds support to show "Enter a topic (skip for general
chat)" as the placeholder when topic is not mandatory in the
move-topic-new-topic input box.
We show "general chat" (as we show in compose topic input box)
when move-topic-new-topic input box is not focused and topic="".
Fixes#33846.
Since the input-group covered all the available space, tooltip looked
like it is separated from the checkbox label. This commit fixes the
width of input-group to be just wide enough to contain the content
when the setting is disabled so that tooltip is positioned correctly.
This commit enables the retry button even when the loading indicator
is being shown, and hides the loading indicator in favor of the original
button content to indicate that the button is still interactable.
Fixes part of #33924.
bold_current_selection is a field within the options returned by
get_options, not a field on DropdownWidgetOptions itself.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Auto scrolling to view the new message is not working.
This bug was introduced in 238c35f2af.
Fixed by passing `messages_are_new` in the relevant functions.
This commit updates the code which computes the dict for
setting groups mapping named user groups to ID and anonymous
groups to UserGroupMembersDict. After the changes, the dict
contains only anonymous groups values and the setting values
for group IDs not present in dict will be computed based on
the fact that those are named user groups.
This is a preparatory refactor for optimizing computing group
setting values for register response by fetching all anonymous
groups membership data just once.
Previously we collapsed buttons when the two-panel view was narrow enough
that the buttons started wrapping, but this case for one-panel view with
wrapping buttons was missed.
