Previously, long owner names could wrap onto two lines in the bot
management modal, breaking the layout. This commit adds CSS to keep
names on a single line and abbreviate with an ellipsis if too long.
Fixes#23266.
Earlier, we removed topic display name for empty topic operand when
query was for topic autocomplete. But we should make sure that we
only do this for the last search term in the suggestion which
corresponds to the typed query and not any previously selected
entered search term. Also recently we removed subset suggestions,
so can safely check it for last search term for all suggestions.
This commit fixes this by checking if the topic suggestion is the
last search_term in the suggestion/search_terms.
Co-authored-by: Evy Kassirer <evy@zulip.com>
While searching in left sidebar, if you collapse a folder, muted
or inactive channels are still visible.
This is due specificity of hiding the channel when folder is
collapsed was lower than that of showing it when a search
is active.
Fixed by increasing the specificity of hiding it when folder
is collapsed.
Earlier, when generating redirect url for search exit, we did not
encode the url in case of topic narrows. We expect some characters
to be replaced when generating hash.
This commit encodes the url for channels and topic narrows and
prevents redirecting to broken hashes.
Earlier, we would show subset suggestions for current search pills
in the suggestion list. Like if `is:dm`, `is:mentioned` and `has:link`
are already selected in the searchbox, we would show
`is:dm, is:mentioned` and `is:dm` again in the suggestion.
This commit removes subset suggestions for current search pills
from the suggestion line.
Previously, clicking on links with the composebox open
didn't close it.
7391a2983f introduced a bug
where the composebox focus logic wasn't triggered at all
if drag evidence wasn't present on the target.
We now do a `e.target.closest("a").length > 0` check
like before and only prevent the default click behavior if
dragging on the target link is detected.
This allows normal link clicks to trigger the
previous composebox focus trigger logic.
Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/composebox.20closes.20when.20going.20to.20recent.20conversations
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
This commit updates the topic URL in the message header topic menu
popover, introduced in feedb6ea2d to a
permalink having a `with` operator attached to it.
Similar to drafts, identify when a scheduled message will be sent to
the logged-in user. This allows the UI to show 'You' as the header for
self-scheduled messages, improving the user experience.
Adding "text-align: start" css to banner-label element makes
sure that the banner text is not aligned as per the alignment
of parent element, as we require left alignment of text for
all the banners. Only navbar banners have text align in center
but that is handled by adjusting the flex layout of the
banner-content, parent of banner-label, element.
We use the same "v" key for opening and closing the
lightbox overlay.
We already have code to open and close the lightbox
overlay in hotkey.ts.
Having another keydown handler for closing the overlay
resulted in a bug where the overlay was just not being
opened because the second handler was immediately called
to close the overlay was immediately called after the first.
Fixes#35868.
URL hash from old url is lost using this JS method for redirecting,
preserved by extracting the hash and appending it to the new URL.
In case user clicks on the new url link, we do this by updating that url to
include the hash, and using that URL for the automated redirect as well.
